From owner-freebsd-stable@FreeBSD.ORG Thu Mar 23 18:40:51 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9790816A400 for ; Thu, 23 Mar 2006 18:40:51 +0000 (UTC) (envelope-from joao@matik.com.br) Received: from msrv.matik.com.br (msrv.matik.com.br [200.152.83.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED29943D5A for ; Thu, 23 Mar 2006 18:40:50 +0000 (GMT) (envelope-from joao@matik.com.br) Received: from anb (anb.matik.com.br [200.152.83.34]) by msrv.matik.com.br (8.13.4/8.13.1) with ESMTP id k2NIeBj6023908; Thu, 23 Mar 2006 15:40:11 -0300 (BRT) (envelope-from joao@matik.com.br) From: JoaoBR To: "Kevin Oberman" Date: Thu, 23 Mar 2006 15:40:32 -0300 User-Agent: KMail/1.9.1 References: <20060323182910.1190845041@ptavv.es.net> In-Reply-To: <20060323182910.1190845041@ptavv.es.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200603231540.33339.joao@matik.com.br> X-Filter-Version: 1.11a (msrv.matik.com.br) X-Virus-Scanned: ClamAV version 0.88, clamav-milter version 0.87 on msrv.matik.com.br X-Virus-Status: Clean Cc: freebsd-stable@freebsd.org Subject: Re: nve timeout (and down) regression? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2006 18:40:51 -0000 On Thursday 23 March 2006 15:29, Kevin Oberman wrote: > I am a bit confused. The first addition of sc->pending_txs =3D 0; was > MFC'ed back in December by obrien. > > Check around line 730 of if_nv.c (or whatever it's called in 6.0) > sc->linkup =3D 0; > sc->cur_rx =3D 0; > sc->pending_rxs =3D 0; > + sc->pending_txs =3D 0; > This should mostly eliminate the problem. > this part actually is in the driver but nve still doing timeout and stop=20 imediatly rx/tx > The other patch cited in the message has never been made: > diff -u -r1.7.2.4 if_nve.c > --- if_nve.c 9 Oct 2005 04:18:17 -0000 1.7.2.4 > +++ if_nve.c 27 Oct 2005 09:58:45 -0000 > @@ -727,7 +727,7 @@ > > DEBUGOUT(NVE_DEBUG_INIT, "nve: nve_init_rings - entry\n"); > > - sc->cur_rx =3D sc->cur_tx =3D sc->pending_rxs =3D sc->pending_txs= =3D 0; > + sc->cur_rx =3D sc->cur_tx =3D sc->pending_rxs =3D 0; and I did this part and my NIC is running, as I said still lot of collision= s=20 caused by it but it is running Jo=E3o > /* Initialise RX ring */ > for (i =3D 0; i < RX_RING_SIZE; i++) { > struct nve_rx_desc *desc =3D sc->rx_desc + i; > > > So sc->pending_txs should only be reset to zero only in nve_stop but not > in nve_init_rings? A mensagem foi scaneada pelo sistema de e-mail e pode ser considerada segura. Service fornecido pelo Datacenter Matik https://datacenter.matik.com.br