From owner-cvs-ports@FreeBSD.ORG  Wed Jul  9 06:31:54 2003
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B1F1637B401; Wed,  9 Jul 2003 06:31:54 -0700 (PDT)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 78DEC43F75; Wed,  9 Jul 2003 06:31:51 -0700 (PDT)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from [128.131.111.52] (naos [128.131.111.52])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id B460913791; Wed,  9 Jul 2003 15:31:49 +0200 (CEST)
Date: Wed, 9 Jul 2003 15:31:47 +0200 (CEST)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: <20030708223311.GA37508@rot13.obsecurity.org>
Message-ID: <Pine.BSF.4.56.0307091452180.22140@naos.dbai.tuwien.ac.at>
References: <200307080902.h6892exF063407@repoman.freebsd.org>
 <Pine.BSF.4.56.0307090025060.86235@acrux.dbai.tuwien.ac.at>
 <20030708223311.GA37508@rot13.obsecurity.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/emulators/wine Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jul 2003 13:31:55 -0000

On Tue, 8 Jul 2003, Kris Kennaway wrote:
>> [...] still I would expect the port build machinery to consier
>> ${PREFIX}/lib when looking for libraries.)
> Not every port installs libraries into ${PREFIX}/lib; a lot of ports
> install them elsewhere.  I'm not sure how you propose to accomodate this.

Well, I'm not necessarily shooting for a perfect solution, just trying
to improve. ;-)

If a user wants to put the XY port under ${PREFIX}, I think it's natural
to try to find prerequisites for XY under ${PREFIX} as well, isn't it?

(And note that in this case it wasn't even some special prefix; rather,
the configure script of emulators/wine failed to find libraries which
were in fact present in /usr/local/lib.)


Now I know that you're a busy man ;-), so I cooked up a patch which should
do what I suggested (tested using an unfixed version of emulators/wine).

Gerald

Index: bsd.port.mk
===================================================================
RCS file: /sw/FreeBSD/CVSUP/ports/Mk/bsd.port.mk,v
retrieving revision 1.455
diff -u -3 -p -r1.455 bsd.port.mk
--- bsd.port.mk	6 Jul 2003 23:54:33 -0000	1.455
+++ bsd.port.mk	9 Jul 2003 13:08:10 -0000
@@ -2213,6 +2213,8 @@ CONFIGURE_LOG?=		config.log

 .if defined(GNU_CONFIGURE)
 CONFIGURE_ARGS+=	--prefix=${PREFIX} ${CONFIGURE_TARGET}
+LDFLAGS+=		-L${PREFIX}/lib
+CONFIGURE_ENV+=		LDFLAGS="${LDFLAGS}"
 HAS_CONFIGURE=		yes
 .endif