Date: Sat, 10 Sep 2011 12:21:52 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-multimedia@freebsd.org Cc: Andriy Gapon <avg@freebsd.org> Subject: Re: Fwd: Trivial sound fix that should be in 9. Message-ID: <201109101221.52950.hselasky@c2i.net> In-Reply-To: <4E6B2B42.3040006@FreeBSD.org> References: <20110908212945.GA22059@darkbeer.org> <4E6B2B42.3040006@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 10 September 2011 11:17:54 Andriy Gapon wrote: > Can anyone on this list please review the following PR and patch? > It seems sufficiently trivial, so if nobody reviews or objects to it, I > will try to ask for RE approval of this patch in a couple of days. > > -------- Original Message -------- > > A while back a colleague sent this fix in for OSS4 it's extremely trivial > and should really make it into 9 as more software is being affected. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=156433 > > Since ariff has been idle for a while it was suggested I send an email to > the last person to touch the file. > Hi, Except for the style, the patch looks good. IOCTL arguments are however not bigger than 32-bit, even though unsigned long is used. I think the problem here is sign-extension from int to unsigned long. If the xcmd was unsigned int, that would solve the problem aswell. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109101221.52950.hselasky>