Date: Tue, 3 Jul 2018 08:21:58 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> Cc: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd Message-ID: <a85b3bc0-d170-84e1-4c83-a1e4d657cd13@FreeBSD.org> In-Reply-To: <20180703150203.GA34086@bsdpad.com> References: <201807031353.w63DrsAa079940@repo.freebsd.org> <980f862d-02d0-a1ce-cf4c-1d39021013fb@FreeBSD.org> <20180703150203.GA34086@bsdpad.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/3/18 8:02 AM, Ruslan Bukin wrote: > On Tue, Jul 03, 2018 at 07:57:00AM -0700, John Baldwin wrote: >> On 7/3/18 6:53 AM, Ruslan Bukin wrote: >>> Author: br >>> Date: Tue Jul 3 13:53:54 2018 >>> New Revision: 335888 >>> URL: https://svnweb.freebsd.org/changeset/base/335888 >>> >>> Log: >>> o Ensure va_list is declared by including stdarg.h. >>> o Also move printf.h to go after it since it does require declaration >>> of va_list. >>> >>> This fixes build with latest RISC-V GNU Toolchain with GCC 8.1 >> >> Normal style(9) is to sort headers. Also, <printf.h> includes <stdio.h> already >> so should already have va_list defined. I think there is some other build problem >> you are running into with GCC 8.1. Did you ensure you stripped all of the >> 'include-fixed' headers when you updated riscv64-gcc? This seems to be an issue >> of busted headers in the compiler and these changes should probably be reverted. >> > > What do you mean stripped? Should I do something with this directory The xtoolchain ports and base/gcc remove these entirely since GCC usually breaks them. You can just remove that directory if you are building by hand. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a85b3bc0-d170-84e1-4c83-a1e4d657cd13>