Date: Sun, 14 Aug 2011 17:53:08 +0200 From: Niclas Zeising <niclas.zeising@gmail.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224842 - head/sys/kern Message-ID: <4E47EF64.2070405@gmail.com> In-Reply-To: <201108131603.p7DG3e80023093@svn.freebsd.org> References: <201108131603.p7DG3e80023093@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2011-08-13 18:03, Robert Watson wrote: > Author: rwatson > Date: Sat Aug 13 16:03:40 2011 > New Revision: 224842 > URL: http://svn.freebsd.org/changeset/base/224842 > > Log: > When falloc() was broken into separate falloc_noinstall() and finstall(), > a bug was introduced in kern_openat() such that the error from the vnode > open operation was overwritten before it was passed as an argument to > dupfdopen(). This broke operations on /dev/{stdin,stdout,stderr}. Fix > by preserving the original error number across finstall() so that it is > still available. > > Approved by: re (kib) > Reported by: cognet > > Modified: > head/sys/kern/vfs_syscalls.c > It might be worth mentioning this in UPDATING or similar, since a kernel built with clang (I haven't tried gcc) during this window will make it impossible to do a buildworld without first rebuilding the kernel with this fix. It also seems to break at least portsnap, and possibly other tools as well. Regards! -- Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E47EF64.2070405>