From owner-svn-src-head@FreeBSD.ORG Sun Aug 14 15:53:16 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 646141065670; Sun, 14 Aug 2011 15:53:16 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) by mx1.freebsd.org (Postfix) with ESMTP id E1E0F8FC13; Sun, 14 Aug 2011 15:53:15 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 8E84C4001B; Sun, 14 Aug 2011 17:53:14 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 83D0340021; Sun, 14 Aug 2011 17:53:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL,FREEMAIL_FROM autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (mx.daemonic.se [IPv6:2001:470:dca9:0:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 4D1A24001B; Sun, 14 Aug 2011 17:53:14 +0200 (CEST) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2001:470:dca9:0:1::4]) by mx.daemonic.se (Postfix) with ESMTPS id E23D8119C04; Sun, 14 Aug 2011 17:53:13 +0200 (CEST) Received: from [IPv6:2001:470:dca9:1::4] (vivi.daemonic.se [IPv6:2001:470:dca9:1::4]) by mail.daemonic.se (Postfix) with ESMTPSA id C93FB12B0A0; Sun, 14 Aug 2011 17:53:13 +0200 (CEST) Message-ID: <4E47EF64.2070405@gmail.com> Date: Sun, 14 Aug 2011 17:53:08 +0200 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Robert Watson References: <201108131603.p7DG3e80023093@svn.freebsd.org> In-Reply-To: <201108131603.p7DG3e80023093@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224842 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2011 15:53:16 -0000 On 2011-08-13 18:03, Robert Watson wrote: > Author: rwatson > Date: Sat Aug 13 16:03:40 2011 > New Revision: 224842 > URL: http://svn.freebsd.org/changeset/base/224842 > > Log: > When falloc() was broken into separate falloc_noinstall() and finstall(), > a bug was introduced in kern_openat() such that the error from the vnode > open operation was overwritten before it was passed as an argument to > dupfdopen(). This broke operations on /dev/{stdin,stdout,stderr}. Fix > by preserving the original error number across finstall() so that it is > still available. > > Approved by: re (kib) > Reported by: cognet > > Modified: > head/sys/kern/vfs_syscalls.c > It might be worth mentioning this in UPDATING or similar, since a kernel built with clang (I haven't tried gcc) during this window will make it impossible to do a buildworld without first rebuilding the kernel with this fix. It also seems to break at least portsnap, and possibly other tools as well. Regards! -- Niclas Zeising