Date: Tue, 23 Jan 2001 16:34:18 -0800 From: Alfred Perlstein <bright@wintelcom.net> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c Message-ID: <20010123163418.N26076@fw.wintelcom.net> In-Reply-To: <200101240026.f0O0QJ513283@freefall.freebsd.org>; from jhb@FreeBSD.org on Tue, Jan 23, 2001 at 04:26:19PM -0800 References: <200101240026.f0O0QJ513283@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [010123 16:26] wrote: > jhb 2001/01/23 16:26:19 PST > > Modified files: > sys/isofs/cd9660 cd9660_vfsops.c > Log: > Proc locking to protect p_ucred while we obtain additional references. I really don't think you need the PROC_LOCK for these. You only need the 'uc' variable, and even then it's only to protect against rfork threads playing with setuid which is an inhernent race condition as p_ucred shouldn't be NULL. (afaik). Therefore you only need to grab a "snapshot" of p_ucred which you do in order to make sure that the same thing that you're crhold'ing is the same thing that you're passing to the VOP. Just give it some more thought, because I'm not sure I'm right about this. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010123163418.N26076>