From owner-freebsd-commit  Sun May 21 18:43:10 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id SAA04168
          for commit-outgoing; Sun, 21 May 1995 18:43:10 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id SAA04153
          for cvs-ports-outgoing; Sun, 21 May 1995 18:42:58 -0700
Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id SAA04144
          ; Sun, 21 May 1995 18:42:52 -0700
Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id SAA18778; Sun, 21 May 1995 18:42:50 -0700
Date: Sun, 21 May 1995 18:42:50 -0700
Message-Id: <199505220142.SAA18778@silvia.HIP.Berkeley.EDU>
To: jhs@freefall.cdrom.com
CC: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com
In-reply-to: <199505212237.PAA00464@freefall.cdrom.com> (message from Julian Stacey on Sun, 21 May 1995 15:37:50 -0700)
Subject: Re: cvs commit: ports/comms/hylafax - Imported sources
From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=)
Sender: commit-owner@FreeBSD.org
Precedence: bulk

 *   Reviewed by:	Earlier draft reviewed by Satoshi (Thanks)

Julian, I asked you to send me a mail when you are done, not to commit
it.  All I did at that time was to make some comments on your 100+
line Makefile, I haven't taken a look at any of your numerous
auxiliary scripts and I haven't done any testing.

I regret your decision to ignore what I said.

 *   I will maintain ports/comms/hylafax as I need fax capability.

You haven't demonstrated you can maintain the port (see below), this
isn't an excuse to import something I can't understand.

 *   Thanks to Asami Satoshi for suggested improvements,
 *   I leave him to `bless' this port by adding the final
 *           comms/Makefile: SUBDIR += hylafax
 *   Until he does that, any mistakes I may have made shouldnt break
 * any makes :-) 

You don't understand.  I do NOT want a broken or messy port in the
tree.  Whether it's referred to by the parent Makefile is irrelevant,
and I want NO ports in the BROKEN list, that list exists for things
that worked before but don't anymore because of one reason or another,
not to squeeze in things that are known to be broken to begin with.

I tried to fix the Makefile now, added EXTRACT_SUFX and deleted the
useless echo statements in the pre-fetch target, re-made the checksums
but it now has 17 (!) failed hunks of patches.

If you can't fix this within 24 hours, expect it to be purged from the 
repository and replaced by another, simpler and working version.

Satoshi