From owner-cvs-src@FreeBSD.ORG Tue Jan 31 19:05:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B156D16A420; Tue, 31 Jan 2006 19:05:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9498443D5A; Tue, 31 Jan 2006 19:05:15 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 15D7946B88; Tue, 31 Jan 2006 14:05:06 -0500 (EST) Date: Tue, 31 Jan 2006 19:07:05 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Baldwin In-Reply-To: <200601311340.51250.jhb@freebsd.org> Message-ID: <20060131190547.Y95776@fledge.watson.org> References: <200601272313.k0RNDQHI064747@repoman.freebsd.org> <20060128141445.GC2341@turion.vk2pj.dyndns.org> <200601311340.51250.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/conf files options src/sys/kern kern_rwlock.c subr_lock.c src/sys/sys lock.h rwlock.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 19:05:18 -0000 On Tue, 31 Jan 2006, John Baldwin wrote: > On Saturday 28 January 2006 09:14, Peter Jeremy wrote: >> On Fri, 2006-Jan-27 23:13:26 +0000, John Baldwin wrote: >>> Log: >>> Add a basic reader/writer lock implementation to the kernel. >> >> Thank you. This looks interesting. >> >>> Tested on: i386 (4 cpu box with a kernel module that used 4 threads >>> that randomly chose between read locks and write locks >>> that ran w/o panicing for over a day solid. It usually >>> panic'd within a few seconds when there were bugs during >>> testing. :) The kernel module source is available on >>> request.) >> >> Can I suggest that this module be committed into tools/regression or >> similar so that it is generally available. > > I can I guess. I have 3 currently (crash, evtest, and crash2 (which is the > latest one that uses multiple threads, crash just has a single thread)). It would be nice of we had something on the order of src/sys/test, where we could put test kernel code that is never intended to see production. The problem with putting things in src/tools is that the code gets very stale, very quickly, as kernel APIs move and the implementation in that tree doesn't. I have some synchronization micro-benchmarks and memory allocation micro-benchmarks I use as part of the netperf work, and they would similarly benefit from a central but non-productionable place in the src/sys tree. Robert N M Watson