Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Apr 2018 08:16:09 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r332773 - head/etc/rc.d
Message-ID:  <201804191516.w3JFG99V066371@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201804191502.w3JF2sgQ051472@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: kevans
> Date: Thu Apr 19 15:02:53 2018
> New Revision: 332773
> URL: https://svnweb.freebsd.org/changeset/base/332773
> 
> Log:
>   Fix ddb rc script
>   
>   r288291 added a call to limits(1), which isn't available before partitions
>   are mounted. This broke the ddb rc script, which does not provide its own
>   start_cmd.
>   
>   Alleviate the situation here by providing a start_cmd. We still have other
>   problems with diskless setups that need to be considered, but this is a
>   start.

Thanks,
Also didn't cy identify a second one of these?
Or am I confusing yet another issue?

>   PR:		206291
>   Submitted by:	cy
>   Discussed with:	rgrimes
>   MFC after:	3 days
> 
> Modified:
>   head/etc/rc.d/ddb
> 
> Modified: head/etc/rc.d/ddb
> ==============================================================================
> --- head/etc/rc.d/ddb	Thu Apr 19 15:02:42 2018	(r332772)
> +++ head/etc/rc.d/ddb	Thu Apr 19 15:02:53 2018	(r332773)
> @@ -15,6 +15,7 @@ desc="DDB kernel debugger"
>  rcvar="ddb_enable"
>  command="/sbin/${name}"
>  start_precmd="ddb_prestart"
> +start_cmd="ddb_start"
>  stop_cmd=":"
>  
>  ddb_prestart()
> @@ -23,6 +24,11 @@ ddb_prestart()
>  	if [ -z "`sysctl -Nq debug.ddb.scripting.scripts`" ]; then
>  		return 1
>  	fi
> +}
> +
> +ddb_start()
> +{
> +	${command} ${command_args}
>  }
>  
>  load_rc_config $name
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804191516.w3JFG99V066371>