From owner-p4-projects Fri May 3 11:42:38 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 46DC237B41D; Fri, 3 May 2002 11:42:34 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from 12-234-96-171.client.attbi.com (12-234-96-171.client.attbi.com [12.234.96.171]) by hub.freebsd.org (Postfix) with ESMTP id BBF9F37B416 for ; Fri, 3 May 2002 11:42:32 -0700 (PDT) Received: by 12-234-96-171.client.attbi.com (Postfix, from userid 1000) id BCC43A900; Fri, 3 May 2002 11:46:25 -0700 (PDT) Date: Fri, 3 May 2002 11:46:25 -0700 From: Jonathan Mini To: Julian Elischer Cc: Perforce Change Reviews Subject: Re: PERFORCE change 10740 for review Message-ID: <20020503114625.E81190@stylus.haikugeek.com> References: <20020503085009.C81190@stylus.haikugeek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from julian@elischer.org on Fri, May 03, 2002 at 09:38:17AM -0700 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian Elischer [julian@elischer.org] wrote : > I have no problem with calling it thread_alloc except that your reason was > spurious. (the clash with "itself"). Oh, totally. That commit deserves a little dunce cap. ;) > > > > - uma_zalloc(,M_WAITOK) will never return NULL, so don't bother > > > > testing for it. > > > > > > You may be right, but I wasn't convinced that M_WAITOK was always > > > correct. I was trying to concieve af a case where you may not ba able to > > > wait when trying ot allocate a new thread.. > > > for example if you are trying to allocate it when you are already in > > > msleep().. it may be bad to sleep when in msleep already... > > > I think I may have other ways to stop this but think about it and > > > check the anti-recursion code in msleep(). > > > It may be that M_NOWAIT is the right answer.. > > > > Hmm. Why would you allocate a thread from within msleep()? > > > Umm MOST threads are allocated from either msleep or fork. > > remember in a threaded process you allocate and activate a new thread > when the old one blocks (i.e. is in msleep()). > So to answer your question.. > this is about the most common case.. :-) Oh. I was under the mistaken impression that threads were only created in fork(). -- Jonathan Mini http://www.haikugeek.com "He who is not aware of his ignorance will be only misled by his knowledge." -- Richard Whatley To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message