Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jul 2006 21:04:16 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 101294 for review
Message-ID:  <200607112104.k6BL4GKX004229@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=101294

Change 101294 by jhb@jhb_mutex on 2006/07/11 21:03:34

	Remove an attempted optimization that didn't help.

Affected files ...

.. //depot/projects/smpng/sys/i386/include/cpufunc.h#33 edit

Differences ...

==== //depot/projects/smpng/sys/i386/include/cpufunc.h#33 (text+ko) ====

@@ -42,8 +42,6 @@
 #error this file needs sys/cdefs.h as a prerequisite
 #endif
 
-#include <machine/psl.h>
-
 struct region_descriptor;
 
 #define readb(va)	(*(volatile u_int8_t *) (va))
@@ -622,16 +620,14 @@
 	register_t eflags;
 
 	eflags = read_eflags();
-	if (eflags & PSL_I)
-		disable_intr();
+	disable_intr();
 	return (eflags);
 }
 
 static __inline void
 intr_restore(register_t eflags)
 {
-	if (eflags & PSL_I)
-		enable_intr();
+	write_eflags(eflags);
 }
 
 #else /* !(__GNUCLIKE_ASM && __CC_SUPPORTS___INLINE) */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607112104.k6BL4GKX004229>