From owner-svn-src-all@FreeBSD.ORG Tue Apr 14 10:30:23 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3E44106566C; Tue, 14 Apr 2009 10:30:23 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 501838FC13; Tue, 14 Apr 2009 10:30:23 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id B688C1CD22; Tue, 14 Apr 2009 12:30:22 +0200 (CEST) Date: Tue, 14 Apr 2009 12:30:22 +0200 From: Ed Schouten To: Bruce Evans Message-ID: <20090414103022.GI32098@hoeg.nl> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090413161812.GD32098@hoeg.nl> <20090414202138.O53192@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xSXKkePCxtN78XFb" Content-Disposition: inline In-Reply-To: <20090414202138.O53192@delplex.bde.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: Revert unneeded changes of r190919 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 10:30:24 -0000 --xSXKkePCxtN78XFb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Bruce Evans wrote: > Review of what I can quote easily in mail: this url appears to be > syntactically correct. > > This is OK, but I would prefer to use temporary hacks in machdep.c > than to mess up cpufunc.h with macros. Temporary until machdep.c is > done right. In one right version, a file other than machdep.c would > provide all the functions in cpufunc.h as extern functions callable > by ddb, and _all_ the functions in cpufunc.h certainly shouldn't be > messed up with macros. Yes, that's true. I guess I'll just change volatile -> __volatile in cpufunc.h to match the rest of the file. --=20 Ed Schouten WWW: http://80386.nl/ --xSXKkePCxtN78XFb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAknkZb4ACgkQ52SDGA2eCwUdAQCePq3eOwcvaHNLbFQU1hhHgsVI Dp4An28fKLiwba1SOBpSHC9B+wptMAh3 =djG9 -----END PGP SIGNATURE----- --xSXKkePCxtN78XFb--