From owner-freebsd-bugs@FreeBSD.ORG  Fri Mar  5 08:30:12 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C7E516A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  5 Mar 2004 08:30:12 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0515343D2D
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  5 Mar 2004 08:30:12 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i25GUBbv079226	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 5 Mar 2004 08:30:11 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i25GUBj4079225;
	Fri, 5 Mar 2004 08:30:11 -0800 (PST)
	(envelope-from gnats)
Date: Fri, 5 Mar 2004 08:30:11 -0800 (PST)
Message-Id: <200403051630.i25GUBj4079225@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Bruce Evans <bde@zeta.org.au>
Subject: Re: bin/63718: lptcontrol.c has unused PATH_LPCTL definition.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Bruce Evans <bde@zeta.org.au>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2004 16:30:12 -0000

The following reply was made to PR bin/63718; it has been noted by GNATS.

From: Bruce Evans <bde@zeta.org.au>
To: "Gary W. Swearingen" <underway@comcast.net>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/63718: lptcontrol.c has unused PATH_LPCTL definition.
Date: Sat, 6 Mar 2004 03:26:14 +1100 (EST)

 [Qouting everything since so that it gets sent to gnats]
 
 On Thu, 4 Mar 2004, Gary W. Swearingen wrote:
 
 > Thanks Bruce.  Some of that went over my head, but here's a
 > replacement patch that seems to work.  (My use of the stock lptcontrol
 > was giving "lptcontrol: open: Device busy" which the patch fixes.)  I
 > slipped in an improvement (?) to the "usage" string.
 >
 > I tested (?) it by "making" it an running the new program without
 > error, but I know of no way to determine whether it actually changed
 > lpt0's mode.
 >
 > I'll file another PR on the manpage's FILES section later.
 >
 > --- lptcontrol.c.orig	Sat May  3 14:06:37 2003
 > +++ lptcontrol.c	Thu Mar  4 09:06:06 2004
 > @@ -46,8 +46,7 @@
 >  #include <sys/types.h>
 >
 >
 > -#define PATH_LPCTL	_PATH_DEV "lpctl"
 > -#define DEFAULT_DEVICE	_PATH_DEV "lpt0"
 > +#define DEFAULT_DEVICE	_PATH_DEV "lpt0.ctl"
 >  #define IRQ_INVALID	-1
 >  #define DO_POLL		0
 >  #define USE_IRQ		1
 > @@ -56,7 +55,7 @@
 >
 >  static void usage(void)
 >  {
 > -	fprintf(stderr, "usage: lptcontrol -i | -p | -s | -e [-d device]\n");
 > +	fprintf(stderr, "usage: lptcontrol -i | -p | -s | -e [-d lpt-control-device]\n");
 >  	exit(1);
 >  }
 >
 
 Yes, that seems to be all that is necessary.  But I want to change devfs
 name to be the same as in RELENG_4 ("lpctl0").  Then no changes would be
 needed to the man page.
 
 Bruce