From owner-cvs-all Tue Jan 23 17: 5:28 2001 Delivered-To: cvs-all@freebsd.org Received: from VL-MS-MR001.sc1.videotron.ca (relais.videotron.ca [24.201.245.36]) by hub.freebsd.org (Postfix) with ESMTP id 2053137B69E; Tue, 23 Jan 2001 17:05:03 -0800 (PST) Received: from jehovah ([24.201.144.31]) by VL-MS-MR001.sc1.videotron.ca (Netscape Messaging Server 4.15) with SMTP id G7N70E05.GD0; Tue, 23 Jan 2001 20:05:02 -0500 Message-ID: <025601c085a1$eb367f20$1f90c918@jehovah> From: "Bosko Milekic" To: "John Baldwin" , , References: <200101240036.f0O0a4114273@freefall.freebsd.org> Subject: Re: cvs commit: src/sys/kern kern_malloc.c Date: Tue, 23 Jan 2001 20:06:44 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6700 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Baldwin: > jhb 2001/01/23 16:36:04 PST > > Modified files: > sys/kern kern_malloc.c > Log: > Don't grab Giant when calling kmem_alloc/kmem_free as this is just > encouraging other people to follow the same practice. If this is going > to be done, then it should be done inside of those two functions instead. > > Revision Changes Path > 1.79 +1 -5 src/sys/kern/kern_malloc.c We should do this and add the proper (temporary) assertions/invariants/witness checks in there, as soon as possible, then. Several portions of code using the kmem_*() code are doing this right now, as you probably now, and we're just (needlessly) repeating the assertions. I don't mind doing it later this week, when I'm done with what I'm presently working with. -Bosko. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message