Date: Tue, 12 Sep 2006 11:25:18 +0900 From: gnn@FreeBSD.org To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Mike Silbersack <silby@silby.com>, cvs-all@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>, Ruslan Ermilov <ru@FreeBSD.org> Subject: Re: cvs commit: src/sys/netinet tcp_subr.c Message-ID: <m23baxes8h.wl%gnn@neville-neil.com> In-Reply-To: <20060911223812.GA1439@comp.chem.msu.su> References: <200609081309.k88D9GCQ077401@repoman.freebsd.org> <20060908100034.M18039@odysseus.silby.com> <20060908154824.GK40020@FreeBSD.org> <20060911003357.V23530@odysseus.silby.com> <20060911142826.GG27667@FreeBSD.org> <20060911223812.GA1439@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
At Tue, 12 Sep 2006 02:38:13 +0400, Yar Tikhiy wrote: > > On Mon, Sep 11, 2006 at 06:28:26PM +0400, Gleb Smirnoff wrote: > > On Mon, Sep 11, 2006 at 12:36:57AM -0500, Mike Silbersack wrote: > > M> >It stops creating any state (nor socket neither compressed tcptw) for the > > M> >TCP connection, where both endpoints were local. This save a lot of > > M> >resources on servers running HTTP accelerators, or database > > M> >servers+clients. > > M> > > M> I think that you should change the description to say "Do not create TCP > > M> TIME_WAIT entries for local <-> local connections" (or something similar) > > M> to remove the ambiguity, and turn it on by default for 7. This seems like > > M> a good idea, I'm jealous that I didn't think of it. :) > > > > OOh, the sysctl name and its description were discussed with ru@, who > > is our famous nitpicker. If you want to change name or description - > > mail to him. /me hides > > (It was me who suggested a different name for the sysctl in question.) > > IMHO it's time to define a general style for new sysctl names. > The first two points could be a) "foo" vs. "nofoo" for boolean > knobs, and b) underscore usage. > > Presently there seem to be few "nofoo" knobs in the system, e.g.: > > # sysctl -aN | fgrep .no > kern.nodump_coredump -- should be coredump_nodump > net.inet6.icmp6.nodeinfo -- false match > debug.nosleepwithlocks > dev.fxp.0.noflow > > I don't think new ones should be introduced; their logic would be > unnecessarily vague. > > OTOH, there are enough sysctl names containing an underscore to > encourage using it in complex names. An exception could be made > for really short names, such as consisting of not more than 2 words, > each being not longer than 4 letters. > > What do you think about that, folks? I am for it, in particular if it is documented. Later, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m23baxes8h.wl%gnn>