From owner-cvs-all@FreeBSD.ORG Tue Sep 12 03:02:55 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E43AF16A4A7; Tue, 12 Sep 2006 03:02:55 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mrout2-b.corp.dcn.yahoo.com (mrout2-b.corp.dcn.yahoo.com [216.109.112.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48DA943D45; Tue, 12 Sep 2006 03:02:55 +0000 (GMT) (envelope-from gnn@neville-neil.com) Received: from minion.local.neville-neil.com (proxy8.corp.yahoo.com [216.145.48.13]) by mrout2-b.corp.dcn.yahoo.com (8.13.6/8.13.6/y.out) with ESMTP id k8C30l67087226; Mon, 11 Sep 2006 20:00:48 -0700 (PDT) Date: Tue, 12 Sep 2006 11:25:18 +0900 Message-ID: From: gnn@FreeBSD.org To: Yar Tikhiy In-Reply-To: <20060911223812.GA1439@comp.chem.msu.su> References: <200609081309.k88D9GCQ077401@repoman.freebsd.org> <20060908100034.M18039@odysseus.silby.com> <20060908154824.GK40020@FreeBSD.org> <20060911003357.V23530@odysseus.silby.com> <20060911142826.GG27667@FreeBSD.org> <20060911223812.GA1439@comp.chem.msu.su> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-apple-darwin8.7.1) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Mike Silbersack , cvs-all@FreeBSD.org, Gleb Smirnoff , Ruslan Ermilov Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 03:02:56 -0000 At Tue, 12 Sep 2006 02:38:13 +0400, Yar Tikhiy wrote: > > On Mon, Sep 11, 2006 at 06:28:26PM +0400, Gleb Smirnoff wrote: > > On Mon, Sep 11, 2006 at 12:36:57AM -0500, Mike Silbersack wrote: > > M> >It stops creating any state (nor socket neither compressed tcptw) for the > > M> >TCP connection, where both endpoints were local. This save a lot of > > M> >resources on servers running HTTP accelerators, or database > > M> >servers+clients. > > M> > > M> I think that you should change the description to say "Do not create TCP > > M> TIME_WAIT entries for local <-> local connections" (or something similar) > > M> to remove the ambiguity, and turn it on by default for 7. This seems like > > M> a good idea, I'm jealous that I didn't think of it. :) > > > > OOh, the sysctl name and its description were discussed with ru@, who > > is our famous nitpicker. If you want to change name or description - > > mail to him. /me hides > > (It was me who suggested a different name for the sysctl in question.) > > IMHO it's time to define a general style for new sysctl names. > The first two points could be a) "foo" vs. "nofoo" for boolean > knobs, and b) underscore usage. > > Presently there seem to be few "nofoo" knobs in the system, e.g.: > > # sysctl -aN | fgrep .no > kern.nodump_coredump -- should be coredump_nodump > net.inet6.icmp6.nodeinfo -- false match > debug.nosleepwithlocks > dev.fxp.0.noflow > > I don't think new ones should be introduced; their logic would be > unnecessarily vague. > > OTOH, there are enough sysctl names containing an underscore to > encourage using it in complex names. An exception could be made > for really short names, such as consisting of not more than 2 words, > each being not longer than 4 letters. > > What do you think about that, folks? I am for it, in particular if it is documented. Later, George