From owner-cvs-src@FreeBSD.ORG Thu Aug 24 19:33:27 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB49716A4DE; Thu, 24 Aug 2006 19:33:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08C7643D45; Thu, 24 Aug 2006 19:33:26 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7OJXKe4069072; Thu, 24 Aug 2006 15:33:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Thu, 24 Aug 2006 15:22:42 -0400 User-Agent: KMail/1.9.1 References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824101606.414e8bf6@kan.dnsalias.net> <44EDCDD4.6070709@samsco.org> In-Reply-To: <44EDCDD4.6070709@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608241522.43325.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 24 Aug 2006 15:33:24 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1726/Thu Aug 24 14:45:50 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Guido van Rooij , Alexander Kabaev , cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2006 19:33:27 -0000 On Thursday 24 August 2006 12:03, Scott Long wrote: > Alexander Kabaev wrote: > > > On Thu, 24 Aug 2006 15:36:28 +0200 > > Guido van Rooij wrote: > > > > > >>On Thu, Aug 24, 2006 at 09:20:02AM -0400, Alexander Kabaev wrote: > >> > >>>On Thu, 24 Aug 2006 07:37:12 +0000 (UTC) > >>>Guido van Rooij wrote: > >>> > >>> > >>>>guido 2006-08-24 07:37:12 UTC > >>>> > >> > >>[..] > >> > >> > >>>> Log: > >>>> MFC: ipfilter 4.1.13 > >>> > >>>This begs for a question: if ipfilter can not be updated without > >>>breaking the tree anymore, does it belong there in the first place? > >> > >>We could of course also get rid of the tree ;) > >> > >>-Guido > > > > Tree without ipfilter or ipfilter without tree - this is a > > technicality. > > > > Seriously though, I wonder how ipfilter is being tested before being > > checked in? Past two commits by you suggested that no testing was done > > at all. > > > > Missing an added file when doing a check-in is a forgivable mistake, > especially since Guido isn't the author and likely doesn't have as deep > of an understanding of the changes as the author does. And, I do highly > appreciate that Guido is responding quickly to the problems. The > process with ipfilter still isn't perfect, but it's definitely an > improvement over the past. Yes, this is the first import Guido has done, and I think it has gone well relatively speaking. Overall I think ipfilter imports will become less eventful in the future than they have been in the past. -- John Baldwin