Date: Thu, 9 Jul 2015 02:17:48 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Peter Jeremy <peter@rulingia.com>, Doug Rabson <dfr@rabson.org>, Jamie Landeg-Jones <jamie@dyslexicfish.net>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT Message-ID: <CAGHfRMBMhraJfMZFnw4A5_NgNdXWsCKmDfw%2B1MiAbqs0VY%2B32Q@mail.gmail.com> In-Reply-To: <20150709084145.GI2080@kib.kiev.ua> References: <CAPQ4ffuTcN_ytcH7GPY0s6OqWK9qo6MGaVZhOB%2B0ojWfd=fNCg@mail.gmail.com> <201507072241.t67MfsX5085860@hergotha.csail.mit.edu> <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> <CAPQ4ffuuaiWGUthEhux2VrK6ZyHDT=0xd9z8k8f11N=6shdUng@mail.gmail.com> <201507081616.t68GGcY9047713@dyslexicfish.net> <CACA0VUhFjBhPMTr=QD71jEvis9CMSrnpyu=xFiXu27nLeozGJA@mail.gmail.com> <0C541CE5-C322-4273-AE0B-1ACAEACCA096@gmail.com> <20150708222717.GE98562@server.rulingia.com> <20150709084145.GI2080@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 9, 2015 at 1:41 AM, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Thu, Jul 09, 2015 at 08:27:17AM +1000, Peter Jeremy wrote: >> I'm not sure if we want to explicitly document the conditions under which >> gettimeofday() (or clock_gettime()) are implemented in userland vs syscalls >> because that is guaranteed to get stale over time. How about stating that > Of course, we don't. There is no guarantee that the set of conditions > is stable even on the stable branch. > >> these functions are implemented as syscalls only if the AT_TIMEKEEP value >> reported by "procstat -x" is NULL. > Mere presence of AT_TIMEKEEP does not imply the use of the fast path. > E.g. the fast path can be disabled dynamically, or timecounter could be > changed, or libc might be of the wrong version. My imagination stops > there. > > IMO the point of this discussion is to note that test suite tests useless useless -> inapplicable > things. things. -> things [for FreeBSD]. > If somebody run the test suite for libc, she would immediately note > another failing test for the stack protector, which is similar to the > gettimeofday nonsense. Perhaps, but that's assuming that NetBSD implemented gettimeofday in userland, which is doesn't. I agree that this is less applicable for FreeBSD than NetBSD. Please keep in mind that contrib/netbsd-tests came from NetBSD, not FreeBSD. Peter Holm and I tried our best to vet out the issues with the test suite before integrating it in, but there might be issues due to implementation discrepancies between FreeBSD and NetBSD. Thanks, -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMBMhraJfMZFnw4A5_NgNdXWsCKmDfw%2B1MiAbqs0VY%2B32Q>