Date: Mon, 31 Mar 2003 16:37:15 -0800 (PST) From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c Message-ID: <Pine.BSF.4.21.0303311635490.8123-100000@root.org> In-Reply-To: <XFMail.20030331155020.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 31 Mar 2003, John Baldwin wrote: > On 31-Mar-2003 John Baldwin wrote: > > jhb 2003/03/31 12:22:00 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > > if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c > > Log: > > Add missing ()'s so that these drivers all compile again. > > > > Noticed by: jake > > Tested on: i386 (compile) > > Also, the pcn(4) driver still has some possibly bogus locking in > its probe routine. Not sure if other drivers have locks in their > probe routines. Thank you jhb and jake for fixing the KASSERT ()'s. I had options INVARIANTS in my kernel so I'm not sure why this was not caught. I was compiling them as modules so does INVARIANTS not enable KASSERT in modules? I'll do a quick grep for other bogus locking shortly. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0303311635490.8123-100000>