Date: Mon, 3 Sep 2012 12:51:10 +0300 From: Aleksandr Rybalko <ray@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: svn-src-head@freebsd.org, Aleksandr Rybalko <ray@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r240067 - head/sys/kern Message-ID: <20120903125110.4420a12c.ray@freebsd.org> In-Reply-To: <A8FC4639-8B1E-4858-A5E8-33D5A4CBA7CF@gmail.com> References: <201209030852.q838q6lC053405@svn.freebsd.org> <A8FC4639-8B1E-4858-A5E8-33D5A4CBA7CF@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Sep 2012 02:05:15 -0700 Garrett Cooper <yanegomi@gmail.com> wrote: >> On Sep 3, 2012, at 1:52 AM, Aleksandr Rybalko wrote: >> >> > Author: ray >> > Date: Mon Sep 3 08:52:05 2012 >> > New Revision: 240067 >> > URL: http://svn.freebsd.org/changeset/base/240067 >> > >> > Log: >> > Add kern.hintmode sysctl variable to show current state of hints: >> > 0 - loader hints in environment only; >> > 1 - static hints only >> > 2 - fallback mode (Dynamic KENV with fallback to kernel >> > environment) Add kern.hintmode write handler, accept only value 2. >> > That will switch static KENV to dynamic. So it will be possible to >> > change device hints. >> >> ... >> >> > + /* Migrate from static to dynamic hints */ >> > + switch (hintmode) { >> > + case 0: >> > + if (dynamic_kenv) >> > + /* Already here */ >> > + hintmode = value; /* XXX: Need we switch >> > or not ? */ >> > + return (0); >> >> ^^^^ typo (missing braces)? ^^^^ Fixed. >> >> Also, don't you need extra glue for jails? >> >> -Garrett Thanks Garrett! WBW -- Aleksandr Rybalko <ray@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120903125110.4420a12c.ray>