Date: Mon, 18 Sep 2017 19:30:57 +0200 From: Emanuel Haupt <ehaupt@critical.ch> To: Ganael Laplanche <ganael.laplanche@martymac.org> Cc: Mathieu Arnold <mat@freebsd.org>, Ganael LAPLANCHE <martymac@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449897 - in head/ftp/lftp: . files Message-ID: <20170918193057.2ce60958614686e4c05b7ba4@critical.ch> In-Reply-To: <3519270.nZQMiuLpb8@home.martymac.org> References: <201709151007.v8FA706V098815@repo.freebsd.org> <0f14dac3-b02c-7cc1-0250-368a97d259b0@FreeBSD.org> <3519270.nZQMiuLpb8@home.martymac.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ganael Laplanche <ganael.laplanche@martymac.org> wrote:
> On Monday 18 September 2017 14:45:58 Mathieu Arnold wrote:
>
> Hi Mathieu,
>
> > After this, I have build failures:
> >
> > In file included from ./signal.h:52:
> > /usr/include/signal.h:85:38: error: expected ')'
> > int sigpending(sigset_t *) __nonnull(1);
> > ^
> > /usr/include/signal.h:87:44: error: expected ')'
> > int sigsuspend(const sigset_t *) __nonnull(1);
> > ^
> > 2 errors generated.
>
> Yes, those errors are related to the introduction of __nonnull()
> attributes in 11.0 (then removed in 11.1, see r311234). Build
> currently fails on 11.0 (only).
>
> I still have to find a proper fix for those errors (any hint
> appreciated here :p).
Patch:
--- lib/cdefs.h.orig 2017-09-12 14:13:24 UTC
+++ lib/cdefs.h
@@ -282,13 +282,7 @@
# define __attribute_format_strfmon__(a,b) /* Ignore */
#endif
-/* The nonull function attribute allows to mark pointer parameters which
- must not be NULL. */
-#if __GNUC_PREREQ (3,3)
-# define __nonnull(params) __attribute__ ((__nonnull__ params))
-#else
# define __nonnull(params)
-#endif
/* If fortification mode, we warn about unused results of certain
function calls which can lead to problems. */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170918193057.2ce60958614686e4c05b7ba4>