Date: Tue, 23 Jan 2001 17:06:52 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Bosko Milekic <bmilekic@technokratis.com> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_malloc.c Message-ID: <XFMail.010123170652.jhb@FreeBSD.org> In-Reply-To: <025601c085a1$eb367f20$1f90c918@jehovah>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24-Jan-01 Bosko Milekic wrote: > > John Baldwin: > >> jhb 2001/01/23 16:36:04 PST >> >> Modified files: >> sys/kern kern_malloc.c >> Log: >> Don't grab Giant when calling kmem_alloc/kmem_free as this is just >> encouraging other people to follow the same practice. If this is >> going >> to be done, then it should be done inside of those two functions >> instead. >> >> Revision Changes Path >> 1.79 +1 -5 src/sys/kern/kern_malloc.c > > We should do this and add the proper (temporary) > assertions/invariants/witness checks in there, as soon as possible, > then. > Several portions of code using the kmem_*() code are doing this right > now, as > you probably now, and we're just (needlessly) repeating the > assertions. > > I don't mind doing it later this week, when I'm done with what I'm > presently > working with. I have the assertions done, but kmem_alloc() is called really early, so Giant has to be obtained really early. I've got this tested on the x86, but no the alpha. I was going to hold off comitting it until I had tested it on the alpha first. :) > -Bosko. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010123170652.jhb>