From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 15 09:10:12 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0A3616A420 for ; Thu, 15 Sep 2005 09:10:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB4E143D55 for ; Thu, 15 Sep 2005 09:10:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8F9ABfB080119 for ; Thu, 15 Sep 2005 09:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8F9ABmL080118; Thu, 15 Sep 2005 09:10:11 GMT (envelope-from gnats) Resent-Date: Thu, 15 Sep 2005 09:10:11 GMT Resent-Message-Id: <200509150910.j8F9ABmL080118@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Leif Neland Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC5FE16A41F for ; Thu, 15 Sep 2005 09:07:56 +0000 (GMT) (envelope-from root@arnold.neland.dk) Received: from swip.net (mailfe07.swip.net [212.247.154.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D12243D48 for ; Thu, 15 Sep 2005 09:07:55 +0000 (GMT) (envelope-from root@arnold.neland.dk) Received: from arnold.neland.dk ([83.72.129.7] verified) by mailfe07.swip.net (CommuniGate Pro SMTP 4.3.4) with ESMTP id 259177077 for FreeBSD-gnats-submit@freebsd.org; Thu, 15 Sep 2005 11:07:54 +0200 Received: from arnold.neland.dk (localhost [127.0.0.1]) by arnold.neland.dk (8.13.4/8.13.1) with ESMTP id j8F97QSF097579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 15 Sep 2005 11:07:27 +0200 (CEST) (envelope-from root@arnold.neland.dk) Received: (from root@localhost) by arnold.neland.dk (8.13.4/8.13.1/Submit) id j8F97Q1e097573; Thu, 15 Sep 2005 11:07:26 +0200 (CEST) (envelope-from root) Message-Id: <200509150907.j8F97Q1e097573@arnold.neland.dk> Date: Thu, 15 Sep 2005 11:07:26 +0200 (CEST) From: Leif Neland To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/86148: Dirname doesn't take multiple arguments as basename does X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Leif Neland List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 09:10:13 -0000 >Number: 86148 >Category: bin >Synopsis: Dirname doesn't take multiple arguments as basename does >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Sep 15 09:10:11 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Leif Neland >Release: FreeBSD 7.0-CURRENT i386 >Organization: no >Environment: System: FreeBSD arnold.neland.dk 7.0-CURRENT FreeBSD 7.0-CURRENT #5: Thu Aug 25 19:21:48 CEST 2005 root@arnold.neland.dk:/usr/obj/usr/src/sys/ARNOLD i386 >Description: The command /usr/bin/dirname only takes one filename as parameter whereas /usr/bin/basename takes multiple. This is un-orthogonal (?) >How-To-Repeat: # dirname `locate bsd` Usage: ... >Fix: This patch *** dirname.c.org Sun May 22 04:15:26 2005 --- dirname.c Thu Sep 15 10:55:58 2005 *************** *** 66,77 **** argc -= optind; argv += optind; ! if (argc != 1) usage(); ! if ((p = dirname(*argv)) == NULL) ! err(1, "%s", *argv); ! (void)printf("%s\n", p); exit(0); } --- 66,80 ---- argc -= optind; argv += optind; ! if (argc < 1) usage(); ! while (argc--) { ! if ((p = dirname(*argv)) == NULL) ! err(1, "%s", *argv); ! argv++; ! (void)printf("%s\n", p); ! } exit(0); } *************** *** 79,84 **** usage(void) { ! (void)fprintf(stderr, "usage: dirname string\n"); exit(1); } --- 82,87 ---- usage(void) { ! (void)fprintf(stderr, "usage: dirname string [...]\n"); exit(1); } -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. MailScanner thanks transtec Computers for their support. >Release-Note: >Audit-Trail: >Unformatted: