Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Mar 2010 17:06:33 +0000
From:      Rui Paulo <rpaulo@freebsd.org>
To:        Bjoern A. Zeeb <bz@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r205637 - head/sys/netinet6
Message-ID:  <DBC6CD04-1108-4AC8-85A7-753F6D9D03C8@freebsd.org>
In-Reply-To: <201003251029.o2PAT0AW031465@svn.freebsd.org>
References:  <201003251029.o2PAT0AW031465@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 25 Mar 2010, at 10:29, Bjoern A. Zeeb wrote:

> Author: bz
> Date: Thu Mar 25 10:29:00 2010
> New Revision: 205637
> URL: http://svn.freebsd.org/changeset/base/205637
>=20
> Log:
>  We are holding a write lock here so avoid aquiring it twice calling
>  the "locked" version rather than the wrapper function.
>=20
>  MFC after:	6 days
>=20
> Modified:
>  head/sys/netinet6/nd6.c
>=20
> Modified: head/sys/netinet6/nd6.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/netinet6/nd6.c	Thu Mar 25 10:13:21 2010	=
(r205636)
> +++ head/sys/netinet6/nd6.c	Thu Mar 25 10:29:00 2010	=
(r205637)
> @@ -1168,7 +1168,7 @@ nd6_nud_hint(struct rtentry *rt, struct=20


This code is probably missing a:
                LLE_WLOCK_ASSERT(lle);
at the beginning.

>=20
>  	ln->ln_state =3D ND6_LLINFO_REACHABLE;
> 	if (!ND6_LLINFO_PERMANENT(ln)) {
> -		nd6_llinfo_settimer(ln,
> +		nd6_llinfo_settimer_locked(ln,
> 		    (long)ND_IFINFO(rt->rt_ifp)->reachable * hz);
> 	}
> done:

--
Rui Paulo




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DBC6CD04-1108-4AC8-85A7-753F6D9D03C8>