Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Mar 2003 23:30:36 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        "Tim J. Robbins" <tjr@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, "" <cvs-src@FreeBSD.org>, "" <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/kern kern_resource.c
Message-ID:  <20030312231337.N29621@gamplex.bde.org>
In-Reply-To: <200303121124.h2CBOfQg069239@repoman.freebsd.org>
References:  <200303121124.h2CBOfQg069239@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Mar 2003, Tim J. Robbins wrote:

> tjr         2003/03/12 03:24:41 PST
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/kern             kern_resource.c
>   Log:
>   Acquire sched_lock around use of FOREACH_KSEGRP_IN_PROC, accesses
>   to kg_nice and calls to sched_nice() in getpriority() and setpriority()
>   (really donice()).

Locking for read access doesn't seem to be any more useful in getpriority()
than anywhere else.  Even when the value is used before the lock is released
(in the loops), the value may become stale before it gets back to userland,
and having a coherent set of values in the loops is not critical.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030312231337.N29621>