Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Dec 2015 08:42:51 -0800
From:      John Baldwin <john@baldwin.cx>
To:        Garrett Cooper <ngie@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r292975 - stable/10/sys/dev/pci
Message-ID:  <2893860.oDiG4KQizb@ralph.baldwin.cx>
In-Reply-To: <201512310355.tBV3t2VG040656@repo.freebsd.org>
References:  <201512310355.tBV3t2VG040656@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote:
> Author: ngie
> Date: Thu Dec 31 03:55:02 2015
> New Revision: 292975
> URL: https://svnweb.freebsd.org/changeset/base/292975
> 
> Log:
>   MFC r278860:
>   r278860 (by jmg):
>   
>   remove NULL check as M_WAITOK will not return NULL
>   
>   Reviewed by:	jhb
>   Sponsored by:	FreeBSD Foundation

Including the metadata from the HEAD commit in the MFC can be misleading, and
I think it is best ommitted.  For example, I did not review this MFC (and
reviewing MFC's in their own right matters since they may require additional
work than commits to HEAD due to ABI concerns), nor did the Foundation sponsor
the MFC.  Rather, I think MFCs should only specify metadata related to the
actual merge itself.

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2893860.oDiG4KQizb>