Date: Mon, 3 Aug 2015 11:20:16 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: Edward Tomasz Napierala <trasz@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r286234 - head/sys/boot/common Message-ID: <CAGHfRMDPqpDbPPdmcPXShF521_s5x=4uAdYhGiKPSD0SdMtmCQ@mail.gmail.com> In-Reply-To: <55BFAAEB.2020900@FreeBSD.org> References: <201508031627.t73GRbTB092225@repo.freebsd.org> <55BFAAEB.2020900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 3, 2015 at 10:54 AM, Andriy Gapon <avg@freebsd.org> wrote: > On 03/08/2015 19:27, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Mon Aug 3 16:27:36 2015 >> New Revision: 286234 >> URL: https://svnweb.freebsd.org/changeset/base/286234 >> >> Log: >> Fix a problem which made loader(8) load non-kld files twice. > > What was the problem? > The change looks like defensive coding, but it's not clear why the loader would > attempt to load the same file more than once in the first place. > >> For example, without this patch, the following three lines >> in /boot/loader.conf would result in /boot/root.img being preloaded >> twice, and two md(4) devices - md0 and md1 - being created. Repro was something like this IIRC: - Start module load. - Hit a key to interrupt the boot so it drops into the loader prompt. - Hit boot again.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDPqpDbPPdmcPXShF521_s5x=4uAdYhGiKPSD0SdMtmCQ>