From owner-cvs-all  Thu May 21 15:03:40 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id PAA11050
          for cvs-all-outgoing; Thu, 21 May 1998 15:03:40 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from firewall.reed.wattle.id.au (darren2.lnk.telstra.net [139.130.53.33])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA10909;
          Thu, 21 May 1998 15:02:46 -0700 (PDT)
          (envelope-from darrenr@reed.wattle.id.au)
Received: (from root@localhost)
	by firewall.reed.wattle.id.au (8.8.7/8.8.7) id WAA16057;
	Thu, 21 May 1998 22:02:34 GMT
Received: from avalon.reed.wattle.id.au(192.168.1.1) by firewall.reed.wattle.id.au via smap (V1.3)
	id sma016055; Thu May 21 22:02:04 1998
Received: from percival.reed.wattle.id.au. (percival.reed.wattle.id.au [192.168.1.5])
	by avalon.reed.wattle.id.au (8.9.0.Beta3/8.9.0.Beta3) with SMTP id IAA12733;
	Fri, 22 May 1998 08:01:43 +1000 (EST)
From: Darren Reed <darrenr@reed.wattle.id.au>
Message-Id: <199805212201.IAA12733@avalon.reed.wattle.id.au>
Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h
In-Reply-To: <19980521202541.60347@follo.net> from Eivind Eklund at "May 21, 98 08:25:41 pm"
To: eivind@yes.no (Eivind Eklund)
Date: Fri, 22 May 1998 08:01:32 +1000 (EST)
Cc: jkh@time.cdrom.com, gibbs@plutotech.com, jkh@FreeBSD.ORG,
        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL37 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

In some email I received from Eivind Eklund, sie wrote:
> On Thu, May 21, 1998 at 10:12:50AM -0700, Jordan K. Hubbard wrote:
> > > No, no, no.  Create an osreldate.h file instead.  Please?  Using __FreeBSD__
> > > doesn't work because it's tied to the compiler, not the source.
> > 
> > 1. The osreldate.h file just isn't created in time and if we want
> >    our SNAP builds to work for now, this change has to happen.
> >    If we want to work out how to get the osreldate.h file bootstrapped
> >    into place at a later time then that's fine with me, but there's
> >    no use holding up the show until then.
> 
> That was the change I installed and backed out so fast earlier today;
> it unfortunately didn't work.
> 
> > 2. Absolutely *nothing* else in the system that I've been able to
> >    find uses __FreeBSD_version directly in the way that this driver
> >    did.  If this is really a step forward then I'd suggest that
> >    a whole lot more needs changing if self-consistency is also your
> >    goal (and I think it should be, especially where this kind of
> >    stuff is concerned, since other driver writers will imitate it).
> 
> The reason nothing else use __FreeBSD_version directly in this way is
> that we don't provide it to kernel files, and that _suck_.  It is one
> of the biggest hurdles for people attempting to do development outside
> of the FreeBSD tree proper.

FWIW, when the shell setup script for in-kernel compiles of IP Filter is
run, it copies /usr/include/osreldate.h to /sys/sys.

It might not be a "great" idea, but heck, it's better than having nothing
to use.

Darren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message