From owner-svn-src-user@FreeBSD.ORG  Fri Dec  5 22:18:50 2008
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A3EBC1065670
	for <svn-src-user@freebsd.org>; Fri,  5 Dec 2008 22:18:50 +0000 (UTC)
	(envelope-from mat.macy@gmail.com)
Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EAFF8FC14
	for <svn-src-user@freebsd.org>; Fri,  5 Dec 2008 22:18:50 +0000 (UTC)
	(envelope-from mat.macy@gmail.com)
Received: by rv-out-0506.google.com with SMTP id b25so187198rvf.43
	for <svn-src-user@freebsd.org>; Fri, 05 Dec 2008 14:18:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:sender
	:to:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references
	:x-google-sender-auth;
	bh=Del/AFWM5iIlHdaaMVE5N9jHON/47ZXbrQkFTeNWySI=;
	b=mZE5VeWUiL2oGfBHRVo7lLwjjvQV1b9RYgJCI5g7SFnDM8AxHxnla2/6Yh/CpHtacQ
	YqjraG4EAJ+nUejDkjha/e34VUjn2fbZhWo9DqAAm8qLWlhx/Gpk1R0Wb2mKhkY5wkah
	0HnJHtNu2EY3NjS2dGjNvoQXkDWBYE4BhtlK4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references:x-google-sender-auth;
	b=X8Qz074jCvnu4ELBVRRjR8EyIki3eYJEMOqYMAhog9okR2/1lpwhXQSDvUbCj+0sFQ
	33UCLye7oK8WWFOYjJzGU9H+RB75TFdewshL5JextYCONW5e92Xqu6FLyRNgtCWRCWrS
	mQzLTIdnIYSRSdT/Y9ctG3YSvbiVRoQ1XotK4=
Received: by 10.141.197.21 with SMTP id z21mr205173rvp.267.1228515529784;
	Fri, 05 Dec 2008 14:18:49 -0800 (PST)
Received: by 10.141.142.3 with HTTP; Fri, 5 Dec 2008 14:18:49 -0800 (PST)
Message-ID: <3c1674c90812051418q1a81ca0an970d410dd034447c@mail.gmail.com>
Date: Fri, 5 Dec 2008 14:18:49 -0800
From: "Kip Macy" <kmacy@freebsd.org>
Sender: mat.macy@gmail.com
To: "Andrew Gallatin" <gallatin@cs.duke.edu>
In-Reply-To: <4939A723.80601@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200812052116.mB5LGDDr073309@svn.freebsd.org>
	<4939A723.80601@cs.duke.edu>
X-Google-Sender-Auth: cee8849e52b64381
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: Re: svn commit: r185649 - in user/kmacy/HEAD_fast_multi_xmit/sys:
	net sys
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2008 22:18:50 -0000

On Fri, Dec 5, 2008 at 2:11 PM, Andrew Gallatin <gallatin@cs.duke.edu> wrote:
> Kip Macy wrote:
>
>> Log:
>>  add inline helper functions for buf_ring enqueue and free
>
>> +       uint64_t                br_drops;
>
> Do you have any way to make these drops visible in netstat -id,
> or should driver writers regularly mirror br_drops
> into their ifp->if_snd.ifq_drops?

There will be an arbitrary number of buf_rings, so I think that
br_drops should be mirrored in to ifq_drops in the drivers callout.
Incrementing a shared counter on multiple cpus works but is not best
practice from a cache standpoint.


Thanks,
Kip