Date: Mon, 20 Dec 2010 22:26:45 +0300 From: Kirill Ponomarev <ponomarew@gmail.com> To: ohauer@FreeBSD.org Cc: ports@freebsd.org, Mark Murray <markm@FreeBSD.org> Subject: Re: Exim port tidyup. Message-ID: <DADC50CA-F534-4799-9BB0-815738796393@gmail.com> In-Reply-To: <4D0CDA89.1040506@FreeBSD.org> References: <E1PTxUT-000PVA-6H@groundzero.grondar.org> <4D0CDA89.1040506@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 18, 2010, at 7:00 PM, Olli Hauer wrote: > On 2010-12-18 15:10, Mark Murray wrote: >> Hi >>=20 >> I've done a bit of maintenance on a port that I originally wrote, = Exim. >>=20 >> I redid the patches by using the "make makepatch" target (it makes = doing >> maintainance easier, as the patch names are regularised and you get = to >> see diffs easier). >>=20 >> As part of this, there is a minor change to the way Exim works, which = is >> a security feature, due to be default in future Exim releases. In the >> EDITME file, it is ALT_CONFIG_ROOT_ONLY, and if its OK to commit this >> cleanup, then I'd commit that separately. >>=20 >> Is it ok for me to commit this please? >>=20 >> http://people.freebsd.org/~markm/exim.tar.gz >>=20 >> ... and it is straight out of my ports/mail/exim/... tree, with >> CVS/... files intact and ready to go, except that I'd do the >> ALT_CONFIG_ROOT_ONLY bit separately. >>=20 >> M >=20 >=20 > Hi Mark, >=20 > since the old patch-files have a long history I suggest open a > change-request PR to repocopy the files and assign the PR to portmgr. >=20 > If portmgr has done the repocopy you can remove the old patch files > and apply your diff (the only significant change I see is in = src__EDITME) >=20 > Things I miss in your diff > - bump PORTREVISION? (if more than EDITME change) > - remove MD5 from distinfo >=20 > Isn't it easier to remove the targets > o show-options-list > o show-variables-list > from Makefile.options and use only the code from the file options = directly? I fully agree here, repocopy is needed first, before we start renaming = patches. K.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DADC50CA-F534-4799-9BB0-815738796393>