From owner-cvs-all@FreeBSD.ORG Mon Jun 2 20:54:24 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEF8D1065681; Mon, 2 Jun 2008 20:54:23 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from hrndva-omtalb.mail.rr.com (hrndva-omtalb.mail.rr.com [71.74.56.125]) by mx1.freebsd.org (Postfix) with ESMTP id 517608FC1F; Mon, 2 Jun 2008 20:54:23 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from orion.intree.net ([70.62.16.218]) by hrndva-omta03.mail.rr.com with ESMTP id <20080602205422.XXBO15997.hrndva-omta03.mail.rr.com@orion.intree.net>; Mon, 2 Jun 2008 20:54:22 +0000 Received: from mail.cokane.org (unknown [172.31.0.6]) by orion.intree.net (Postfix) with ESMTP id 1D5DC361C2A2; Mon, 2 Jun 2008 16:54:22 -0400 (EDT) Received: by mail.cokane.org (Postfix, from userid 103) id EFCA116B55B; Mon, 2 Jun 2008 16:54:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cokane.org (Postfix) with ESMTP id 8E5D91DB2F9; Mon, 2 Jun 2008 16:54:11 -0400 (EDT) From: Coleman Kane To: John Baldwin In-Reply-To: <200806021445.15974.jhb@freebsd.org> References: <200805151955.m4FJtRMb099378@repoman.freebsd.org> <200806021445.15974.jhb@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-cGTK6yTuKUFhn47pZAbF" Organization: FreeBSD Project Date: Mon, 02 Jun 2008 16:52:48 -0400 Message-Id: <1212439968.3115.53.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 FreeBSD GNOME Team Port Cc: cvs-src@freebsd.org, Stefan Farfeleder , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/bin/sh expand.c parser.c parser.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2008 20:54:24 -0000 --=-cGTK6yTuKUFhn47pZAbF Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2008-06-02 at 14:45 -0400, John Baldwin wrote: > On Thursday 15 May 2008 03:55:27 pm Stefan Farfeleder wrote: > > stefanf 2008-05-15 19:55:27 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > bin/sh expand.c parser.c parser.h=20 > > Log: > > Expand $LINENO to the current line number. This is required by=20 > SUSv3's "User > > Portability Utilities" option. > > =20 > > Often configure scripts generated by the autotools test if $LINENO wo= rks=20 > and > > refuse to use /bin/sh if not. > > =20 > > Package test run by: pav >=20 > This breaks the build of editors/openoffice-2 >=20 > Specifically, the libxslt configure script has two statements like this: >=20 > if test "1" =3D=3D "1" > then > blah blah > endif >=20 > Specifically note the "=3D=3D" passed to test(1). POSIX says this should= be "=3D",=20 > and that's all our test(1) implements. The bash manpage for the builtin-= test=20 > command says: >=20 > string1 =3D=3D string2 > True if the strings are equal. =3D may be used in place of= =3D=3D for > strict POSIX compliance. >=20 > IOW, it encourages "=3D=3D". I'm not sure if we want to force the use of= bash for=20 > certain ports or if we want to just implement bash'isms in our tools as w= e=20 > encounter them (or patch the port?). In this case the patch is not=20 > complicated (just replace the two '=3D=3D' with '=3D' in libxslt's config= ure=20 > script). >=20 This is annoying... I had to clean this behavior up once recently in someone else's script. POSIX "test" syntax has been "=3D" and not "=3D=3D" = for a long time. Bash is not C... so I don't understand why the attempt to document "=3D=3D" as the "proper" operator. My thinking is the offending script should be fixed with a patch that gets forwarded upstream to the libxslt team (including a mention that /bin/sh and /bin/test are not documented to support "=3D=3D" by POSIX). --=20 Coleman Kane --=-cGTK6yTuKUFhn47pZAbF Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkhEXZ4ACgkQcMSxQcXat5couwCbBCocZx962/WVHo99eGJoWDoV c5QAniYKfWzSvpl618aGGPqbYIXCElYc =ntRZ -----END PGP SIGNATURE----- --=-cGTK6yTuKUFhn47pZAbF--