Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Apr 2019 18:09:41 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To:        Yoshihiro Ota <ota@j.email.ne.jp>
Cc:        rgrimes@freebsd.org, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, Michael Reifenberger <mr@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r345804 - head/usr.bin/systat
Message-ID:  <201904030109.x3319f25024050@gndrsh.dnsmgr.net>
In-Reply-To: <20190402210001.3cd9b434a2f521e2dea80009@j.email.ne.jp>

next in thread | previous in thread | raw e-mail | index | archive | help
> Hi,
> 
> On Tue, 2 Apr 2019 07:08:17 -0700 (PDT)
> "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> wrote:
> 
> > > Author: mr
> > > Date: Tue Apr  2 14:01:03 2019
> > > New Revision: 345804
> > > URL: https://svnweb.freebsd.org/changeset/base/345804
> > > 
> > > Log:
> > >   systat -zarc to display disk activities like -vm
> > >   
> > >   PR:		213310
> > >   Submitted by:	ota
> > >   MFH:		4 weeks
> > 
> > ? MFC:
> > 
> > >   Differential Revision:	https://reviews.freebsd.org/D18726
> > > 
> > > Modified:
> > >   head/usr.bin/systat/devs.c
> > >   head/usr.bin/systat/devs.h
> > >   head/usr.bin/systat/iostat.c
> > >   head/usr.bin/systat/swap.c
> > >   head/usr.bin/systat/systat.h
> > >   head/usr.bin/systat/vmstat.c
> > >   head/usr.bin/systat/zarc.c
> > > 
> > > Modified: head/usr.bin/systat/devs.c
> > > ==============================================================================
> > > --- head/usr.bin/systat/devs.c	Tue Apr  2 13:59:04 2019	(r345803)
> > > +++ head/usr.bin/systat/devs.c	Tue Apr  2 14:01:03 2019	(r345804)
> > > @@ -2,6 +2,7 @@
> > >   * SPDX-License-Identifier: BSD-3-Clause
> > >   *
> > >   * Copyright (c) 1998 Kenneth D. Merry.
> > > + *               2015 Yoshihiro Ota
> > >   * All rights reserved.
> > 
> > 
> > Can we get in contact with Yoshihiro Ota about his
> > copyright statements, and correcting this to make
> > it clear that it is Kenneth D. Merry that is asserting
> > "All rights reserved" and if Ota does nor does not wish to assert
> > "All rights reserved".
> > 
> > As committed this makes a grey area on Kenneth's assertion,
> > also leaving out the word copyright on Yoshihiro's line is a bit iffy.
> > 
> > I am only commenting once, this issue appears several times.
> > We can go back out to D18726 to discuss it if need be.
> 
> I've fully written zarc.c (and copied copy-right section from another file)
> but all other changes in other files are refactoring and adjustments.
> 
> I don't know the policy/procedure of how to update copy right section of FreeBSD.
> Please adjust them according the project.
> 
> Regards,
> Hiro
> 

I'll create a review with you as a reviewer that
takes what I believe is the appropriate steps,
and seek your approval for changes to your copyright statements.

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904030109.x3319f25024050>