Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Jun 2016 11:18:56 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Andrey Chernov <ache@freebsd.org>, current@freebsd.org
Subject:   Re: 'make depend' or 'make' bug on recent --current
Message-ID:  <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org>
In-Reply-To: <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org>
References:  <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eLVmTIGcVAkkbkiFnug92E23PGujPS5Uh
Content-Type: multipart/mixed; boundary="ooFp2tckfnjxV8Lftt0vcltN3iCiV1gcB"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Andrey Chernov <ache@freebsd.org>, current@freebsd.org
Message-ID: <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org>
Subject: Re: 'make depend' or 'make' bug on recent --current
References: <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org>
In-Reply-To: <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org>

--ooFp2tckfnjxV8Lftt0vcltN3iCiV1gcB
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 6/1/2016 6:11 AM, Andrey Chernov wrote:
> Steps to reproduce:
>=20
> cd /usr/src/lib/libc/stdlib
> touch *div*.c
> cd ..
> make depend
> make
>=20
> And see how imaxdiv.o only is recompiled.
> No div.o ldiv.o lldiv.o are recompiled.

My dev system is busy at the moment. I'll test it and get back to you.

>=20
> P.S. new make depend is simple disgusting. It tends to recompile
> everything in the system if some minor header file is touched, but

If the header is used by all source files then that is expected.

However if you do not have a .depend.obj.o file then it is quite
aggressive with building.  If you touch any header it will rebuild
everything.  But you shouldn't get into that situation unless you rm -f
=2Edepend* first.

> completely forget to recompile source code changes. I suggest to back
> out all AI in that area.
> 'make depend' is not time-consuming task and good old way never made
> mistakes.

The graph in the original commit for WITH_FAST_DEPEND disagrees.
https://svnweb.freebsd.org/base?view=3Drevision&revision=3D290433

We run the preprocessor once now, not twice.


--=20
Regards,
Bryan Drewery


--ooFp2tckfnjxV8Lftt0vcltN3iCiV1gcB--

--eLVmTIGcVAkkbkiFnug92E23PGujPS5Uh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJXTycQAAoJEDXXcbtuRpfP5eAH+wet3DUxJhrCFcK1UOJaJMTy
UTL+zH8D8FaYIDJDdmqhg5yhIDY+XHfSjitfNWTeqER+2N3er9TBX2V/Ej7EUtMl
ytchGZqsYRtxM/P9ksUZLWv8XNEgDPdU7VQhMSoSedDVpg9BmdNRWRpfuF0jRIrI
rOAhcPh/6eHBXguMnoaikSvseWW9N5HM4HvBhdPT0vEkpVR7YaknS6wwYN6kiSIm
GYJt08FVgJU0xAgetJXOq4NbFnL52Ec0QMuXqm/j2JSYS7RbxGpl9I+uxmt7ERdJ
XTYGtja35DI5N8N4aCFjkQaVEI0RfA8z5sTD7TPVdn6mFg9rvgnY37Ho1z7Ck+I=
=xK2L
-----END PGP SIGNATURE-----

--eLVmTIGcVAkkbkiFnug92E23PGujPS5Uh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?311f3a82-b702-d375-170f-82ae39236ab0>