From owner-freebsd-multimedia@FreeBSD.ORG Tue May 3 07:06:29 2005 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBE1C16A4CE for ; Tue, 3 May 2005 07:06:29 +0000 (GMT) Received: from mail231.csoft.net (resin.csoft.net [63.111.22.86]) by mx1.FreeBSD.org (Postfix) with SMTP id 3642443D62 for ; Tue, 3 May 2005 07:06:29 +0000 (GMT) (envelope-from jakemsr@jakemsr.com) Received: (qmail 10499 invoked from network); 3 May 2005 07:12:35 -0000 Received: from unknown (HELO puff.jakemsr.gom) (63.111.27.87) by mail231.csoft.net with SMTP; 3 May 2005 07:12:35 -0000 Received: (from jakemsr@jakemsr.com) by puff.jakemsr.gom (mini_sendmail/1.3.5 16nov2003); Tue, 03 May 2005 00:06:28 PDT (sender jakemsr@puff.jakemsr.gom) Date: Tue, 3 May 2005 00:06:28 -0700 From: Jacob Meuser To: freebsd-multimedia@freebsd.org Message-ID: <20050503070628.GF11140@puff.jakemsr.gom> Mail-Followup-To: freebsd-multimedia@freebsd.org References: <20050502043610.51034.qmail@exxodus.fedaykin.here> <4275B154.5070007@ahze.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4275B154.5070007@ahze.net> User-Agent: Mutt/1.4.2i Subject: Re: New ffmpeg CVS versions X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2005 07:06:29 -0000 On Mon, May 02, 2005 at 12:49:24AM -0400, Michael Johnson wrote: > Mario Sergio Fujikawa Ferreira wrote: > >Hi, > > <--snip--> > > > > > There are 2 versions of the ffmpeg-devel port: > > > > They are located > > http://people.freebsd.org/~lioux/ffmpeg-devel-20050427.tar.gz > and > http://people.freebsd.org/~lioux/ffmpeg-devel-20050502.tar.gz > > > >1 - build and works > >port -> ffmpeg-cvs-20050427.tar.gz > >distfile -> ffmpeg-devel-20050427.tar.gz > >2 - does not build, it breaks when trying to build the bktr(4) > > grabbing code. I'll appreciate help fixing it > >port -> ffmpeg-cvs-20050502.tar.gz > >distfile -> ffmpeg-devel-20050502.tar.gz > > > > <--snip--> notes on grab_bsdbktr.c no need to pass video_buf into bktr_init(), it's a global variable. i think av_set_pts_info() needs to be moved up to before other parameters in 's' are set in grab_read_header(). i'm pretty sure the av_free() in grab_read_close() can result in double free errors, i.e. ffmpeg free()s the memory automagically. IMO it's bad form to expect opening /dev/tuner* to unmute the audio, and closing it to mute it again, even if that's how it currently works :( http://www.openbsd.org/cgi-bin/cvsweb.cgi/ports/graphics/ffmpeg/files/grab_bsdbktr.c (disregard the mistakes in the previous version :/) --