Date: Fri, 17 Jun 2016 09:51:45 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301959 - head/sys/kern Message-ID: <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org> In-Reply-To: <20160617061306.GS38613@kib.kiev.ua> References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> <20160617061306.GS38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6 Content-Type: multipart/mixed; boundary="HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org> Subject: Re: svn commit: r301959 - head/sys/kern References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> <20160617061306.GS38613@kib.kiev.ua> In-Reply-To: <20160617061306.GS38613@kib.kiev.ua> --HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/16/2016 11:13 PM, Konstantin Belousov wrote: > On Thu, Jun 16, 2016 at 10:17:19AM -0700, Conrad Meyer wrote: >> style(9) nit: /* FALLTHROUGH */ >=20 > FALLTHROUGH is only applicable when there are executable statements for= > both cases, and first sequence of statements does not end in break. > Look at the switch() example right after the FALLTHROUGH requirement > in the style(9), which shows case '?'. >=20 Yes the example shows code in both cases, but the text about it is more strict "Elements in a switch statement that cascade should have a FALLTHROUGH comment." --=20 Regards, Bryan Drewery --HObBJ5hGTFws0doCBSAtRQaJrNbb98SSU-- --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXZCqhAAoJEDXXcbtuRpfPsC0H/jOWJXEkMMI689nbH+iWARaj MEv9UVa3KIo7XH1lnWJnUiQ1np/ihKCwMI/7q/aZbfwBkuT7DWu25Beaow6lE6ii 2Cz0gCLYTq366v7mlhEpE60M8YfG3D6k+AcR2vy7iTtbYDNvFeMCBi+2CqzvP4c6 UGGanycqUJZSCdQ7lkcXp45QDoOIsmvXCagHJHevnBB1Nk62xl/EA82jpW55x4PG MYiWqY/DyilInItofqpNX4/7KsxxHx8W+wbhFu+1GIVxwsErHuJPRQeL0VCsJ4LR Zet+LJHbUQ33m9UsYBzo0ArxmxitnldRn70EnSWaUyetgAXMDOpGTqn/8FeQAOg= =0H0+ -----END PGP SIGNATURE----- --Jt34htBudipOAbaTOakPrNd9fq6xiSCE6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c0f54ecb-c78f-2551-e048-89ef95f3d53f>