Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 09 Feb 2012 03:03:55 +0000
From:      "Philip M. Gollucci" <pgollucci@gmail.com>
To:        Doug Barton <dougb@freebsd.org>
Cc:        FreeBSD ports list <freebsd-ports@freebsd.org>, Alex Dupre <ale@freebsd.org>
Subject:   Re: What use is WWWDIR_REL?
Message-ID:  <4F33379B.5080804@p6m7g8.com>
In-Reply-To: <4F330438.9020800@FreeBSD.org>
References:  <4F31EBE1.8040000@FreeBSD.org> <4F32966F.2070802@FreeBSD.org> <4F330438.9020800@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigE8BC0CDA75BB39872E687DFA
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 02/08/12 23:24, Doug Barton wrote:
> On 02/08/2012 07:36, Alex Dupre wrote:
>> Doug Barton wrote:
>>> So this leads me to many questions, the first and most obvious of whi=
ch
>>> is, what the heck good is WWWDIR_REL in the first place?
>>
>> I don't follow you: in what sense WWWDIR_REL is different from, e.g.,
>> DOCSDIR_REL or DATADIR_REL? Why do you want to remove it and not the
>> others?
>=20
> Looking again at this bit of bpm:
>=20
> PLIST_SUB+=3D     DOCSDIR=3D"${DOCSDIR_REL}" \
>                 EXAMPLESDIR=3D"${EXAMPLESDIR_REL}" \
>                 DATADIR=3D"${DATADIR_REL}" \
>                 WWWDIR=3D"${WWWDIR_REL}" \
>                 ETCDIR=3D"${ETCDIR_REL}"
>=20
> You're right, the silliness is universal. I was focused on WWWDIR
> because I was working with it. They should probably all go away, but I
> don't have the time atm to do an exhaustive search on where/how they ar=
e
> all used.
>=20
>=20
> Doug
>=20
Ah, the lightbulb goes off.

pkg-plist is supposed to be relative to @cwd which may or may not be
${LOCALBASE} or ${PREFIX} hence abs paths should be avoided.

That said, I think dougb's original patch
+		WWWDIR=3D"${WWWDIR:S,^${PREFIX}/,,}"

accomplishes this quite nicely and removes 1-3 variables in the process.



--=20
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Director Operations,              Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.


--------------enigE8BC0CDA75BB39872E687DFA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFPMzeedbiP+9ubjBwRAu34AKCMljI/jT/jL98ELbY2mUZgCaoSVgCggXer
jnULCwemXrgkdDdqsxjZe10=
=C6O/
-----END PGP SIGNATURE-----

--------------enigE8BC0CDA75BB39872E687DFA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F33379B.5080804>