Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 01 Jan 2009 23:43:43 -0800
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn: head/usr.sbin/mergemaster
Message-ID:  <495DC5AF.3050908@FreeBSD.org>
In-Reply-To: <495DB9B6.4030801@FreeBSD.org>
References:  <200901011055.n01AtQaN052763@svn.freebsd.org> <495DB15B.8040908@FreeBSD.org> <495DB9B6.4030801@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton wrote:
> Maxim Sobolev wrote:
>> Doug Barton wrote:
>>> Author: dougb
>>> Date: Thu Jan  1 10:55:26 2009
>>> New Revision: 186677
>>> URL: http://svn.freebsd.org/changeset/base/186677
>>>
>>> Log:
>>>   Revert 184781, 184804, and 184832 (automatic installation of files
>>>   that differ only by VCS Id) for the following reasons:
>>>   1. It was added without my consent, review, or even a heads up
>> Huh? I sent you request for review on 24 October 2008
> 
> If that's the case then I apologize, I've been extremely overloaded
> lately and it's possible that this fell through the cracks.
> 
> My other objections remain however, including the one about the -U
> option being a better solution that requires no new code.

1. -U option requires system to have the copy of the database from the 
previous upgrade. It gives no help on the system that was installed from CD.

2. If the functionality has some issues leading to false positives I can 
investigate and improve/fix.

3. I don't see anything so technically bad about that feature (put aside 
implementation details). I would like to hear some of your principal 
objections.

-Maxim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?495DC5AF.3050908>