Date: Wed, 31 Jul 2013 09:15:27 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Cedric GROSS <cg@cgross.info> Cc: freebsd-wireless@freebsd.org Subject: Re: [IWN] Reviw split 2 Message-ID: <CAJ-Vmo=-TYF3xkBFFMFga8QVjkb0ZoWc%2BuSC47RwwSbjwNoiyg@mail.gmail.com> In-Reply-To: <002701ce8e03$c033f640$409be2c0$@info> References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> <CAJ-VmokCVB5kNY44hJLbAfOb1DMSHmJAG3QTUZYhmPL1gHwMwA@mail.gmail.com> <002d01ce8c46$a13b23d0$e3b16b70$@info> <CAJ-Vmon4hMbgFKaWva3-HhcJv=eUXKwX7s0uPcD9Nu9g86QEbA@mail.gmail.com> <002701ce8e03$c033f640$409be2c0$@info>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks good! I'll commit this soon.
Thanks!
-adrian
On 31 July 2013 08:36, Cedric GROSS <cg@cgross.info> wrote:
>> -----Message d'origine-----
>> De : adrian.chadd@gmail.com [mailto:adrian.chadd@gmail.com] De la part
>> de Adrian Chadd
>> Envoy=E9 : mercredi 31 juillet 2013 17:08
>> =C0 : Cedric GROSS
>> Cc : freebsd-wireless@freebsd.org
>> Objet : Re: [IWN] Reviw split 2
>>
>> Hi,
>>
>> There's some more whitespace things to fix in your diff.
>>
>> -
>> ->......>.......>.......bus_dmamap_sync(sc->rxq.data_dmat, data->map,
>> ->......>.......>....... BUS_DMASYNC_POSTREAD);
>> ->......>.......>.......DPRINTF(sc, IWN_DEBUG_ANY,
>> +>......>.......>.......>.......DPRINTF(sc, IWN_DEBUG_ANY,
>> >......>.......>....... "%s: scanning channel %d status %x\n",
>> >......>.......>....... __func__, scan->chan, le32toh(scan-
>> >status));
>>
>> .. notice how you've indented DPRINTF there? You should fix that. :)
>
> Fixed.
>
>>
>> +#ifdef>IWN_DEBUG
>> +#define IWN_DESC(x) case x:>...return #x #define COUNTOF(array)
>> +(sizeof(array) / sizeof(array[0]))
>>
>> There should be a tab between the #define and the thing you're
>> defining, rather than a space.
>
> Done.
>
>>
>> + * This function print firmawre register
>>
>> .. typo, that should be "firmware" :)
>
> Yep fixed.
>
>>
>> +>......};
>> +>......DPRINTF(sc, IWN_DEBUG_REGISTER,
>> + "CSR values: (2nd byte of IWN_INT_COALESCING is
>> IWN_INT_PERIODIC)%s",
>> + "\n");
>> +>......for (i =3D 0; i < COUNTOF(csr_tbl); i++){
>>
>> .. there needs to be a tab in front of the two lines after the
>> DPRINTF(). Well, strictly speaking, there should be a tab (to bring it
>> to the same indent level) and then four spaces (as it's a continuation
>> of the line above it.)
>
> Fixed
>
>>
>> Now, you're making IWN_DEBUG an option, right? Once you've done this,
>> I'll go make sure you can put it in the kernel config file as a build
>> option (and I'll enable it by default on i386/amd64.)
>
> Yes, I think should be a good thing.
>
>>
>> Thanks!
>>
>>
>> -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=-TYF3xkBFFMFga8QVjkb0ZoWc%2BuSC47RwwSbjwNoiyg>