Date: Wed, 12 Jul 2017 01:09:39 -0700 From: Ryan Libby <rlibby@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: Ryan Libby <rlibby@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320908 - head/sys/kern Message-ID: <CAHgpiFwYvnaG_=Lx1GEOspu21CZEg4=dXuqFhjd_9yOpkj-DBA@mail.gmail.com> In-Reply-To: <20170712074326.GA41347@vlakno.cz> References: <201707120730.v6C7UExf041447@repo.freebsd.org> <20170712074326.GA41347@vlakno.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 12, 2017 at 12:43 AM, Roman Divacky <rdivacky@freebsd.org> wrote: > Clang knows about %b modifier and can do some semantic analysis on it. > Currently it type checks the first arg to be an int and the second to be > a char*. > > Do you think it would be worth modifying the checks to include > this new functionality? Do you think you would like to take a stab > at it? Yes, I plan to send that to clang upstream. I originally had those changes in this commit but I was directed rather to send them first to upstream. See here [1] for roughly what I plan to send upstream (although I have since noticed some unit tests that I guess should be extended). For now, the semantic analysis should be fine as the change should be backward compatible and I haven't yet changed any of the users of %b to use the new capabilities. Ryan [1] https://reviews.freebsd.org/D11284?id=29866
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFwYvnaG_=Lx1GEOspu21CZEg4=dXuqFhjd_9yOpkj-DBA>