From owner-svn-src-all@FreeBSD.ORG Wed Feb 4 14:44:28 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D904A1065670; Wed, 4 Feb 2009 14:44:28 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 61E548FC18; Wed, 4 Feb 2009 14:44:28 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (pD9E2E9D3.dip.t-dialin.net [217.226.233.211]) by redbull.bpaserver.net (Postfix) with ESMTP id C416B2E068; Wed, 4 Feb 2009 15:44:19 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 2FB42101086; Wed, 4 Feb 2009 15:44:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1233758656; bh=5tMn7r6tXLnDzHvngfHvceEkdnFfKXEfP djKftvfAxc=; h=Message-ID:Date:From:To:Cc:Subject:References: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=MHK2vPLIdy61WadSBcTzlRdneqVrysRGwHEclNEVUymVDRxdKgmP6nE8DrBhmTkHR V/Udtt4tYl+SW++osi0TupgH+Srtscg+r0pDYhMwaL961Pl+ZMuWTbx5rutfay09Cob iJF7x+m/SJUl2LZ8pi6z+9fiFH3u6Azv/4kj2p0J74m/SHejSwULSoUaENsuVdzbQaW QxRLVah6LX1s54RPy/+BMwkK1+aw2jIal2nIZkdhIxQxHJqfR4RtuJvAhih6nrcynVF WkY8s1M+L16Bn/jXjlwPa1lMRV6sRvkoq1TFWSWnWwK1IbuyFZUMGqtwcNibXDogpTY 6pJb++HjQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id n14EiFCF018532; Wed, 4 Feb 2009 15:44:15 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 04 Feb 2009 15:44:14 +0100 Message-ID: <20090204154414.1949765y56lfhi80@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 04 Feb 2009 15:44:14 +0100 From: Alexander Leidinger To: Bruce Evans References: <200902032025.n13KPaCV041012@svn.freebsd.org> <4988AB83.2050203@gmx.de> <20090204212854.F51932@delplex.bde.org> In-Reply-To: <20090204212854.F51932@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.3) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: C416B2E068.EA419 X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, ORDB-RBL, SpamAssassin (not cached, score=-13.427, required 6, BAYES_00 -15.00, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, TW_SV 0.08) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Christoph Mallon , Warner Losh , src-committers@freebsd.org Subject: Re: svn commit: r188098 - head/lib/libc/string X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2009 14:44:29 -0000 Quoting Bruce Evans (from Wed, 4 Feb 2009 =20 22:27:59 +1100 (EST)): > On Tue, 3 Feb 2009, Christoph Mallon wrote: > >> Warner Losh schrieb: >>> Modified: head/lib/libc/string/strmode.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>> --- head/lib/libc/string/strmode.c=09Tue Feb 3 20:01:51 2009 (r188097) >>> +++ head/lib/libc/string/strmode.c=09Tue Feb 3 20:25:36 2009 (r188098) >>> @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); >>> #include >>> void >>> -strmode(mode_t mode, char *p) >>> +strmode(/* mode_t */ int mode, char *p) >>> { >>> =09 /* print type */ >>> =09switch (mode & S_IFMT) { >> >> The manpage states that the first parameter of strmode() is a =20 >> mode_t. What's wrong - the implementation (both in header and =20 >> definition) or the documentation? > > The man page is wrong. strtomode() should take an int arg (actually > the default (unary) promotion of a mode_t) for the the same reasons > that memchr() does -- because these interfaces should be usable by K&R > compilers and/or by standard C compilers without a protoype in scope. > Even if this is no longer required, binary compatibily requires the > interfaces to be the same as the ones that used to be required. The > requirement for binary compatibility also prevents "fixing" interfaces > to be "ANSI" in headers (if you "fix" prototypes there then you will > get obscure runtime errors instead of tinderbox errors). Is this also true for the current use of symbol versioning in our =20 libc? I thought this is supposed to "fix" this problem (assuming we =20 add an UPDATING entry that users have to make sure that they to a full =20 installworld to habe the includes and the lib in sync)? Bye, Alexander. --=20 Sometimes the best medicine is to stop taking something. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137