From owner-svn-src-head@FreeBSD.ORG Thu Feb 5 06:22:07 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1888F106566C; Thu, 5 Feb 2009 06:22:07 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id AF4DE8FC16; Thu, 5 Feb 2009 06:22:06 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (pD9E2EA13.dip.t-dialin.net [217.226.234.19]) by redbull.bpaserver.net (Postfix) with ESMTP id 5B3E32E0F8; Thu, 5 Feb 2009 07:22:02 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 0741110DF83; Thu, 5 Feb 2009 07:21:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1233814919; bh=2eftzojt4DJUvciSV8T7xF0AQTQj1dOZ5 cyy3nMUhio=; h=Message-ID:Date:From:To:Cc:Subject:References: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=tMmFVVRTSrMgJ0IkAOyNAfwsPEvlgmja5H/0gR32PPtfEgyGIURhyHknRxLZlv5jF A9O7UCOV7AJcOPk1j/UMf1GgvAwdSvGqHVac7FZfKSzVeZ7XI2URSRJ+RUhepFTmFms 61xozWKTMZEj3O/I/nxy5u8nLn5U1O6O4690cW4HQQ+z9caISjIoOQBTsrNt5zs5t8R oWAM0ZgCyPYO9dlFeE3sxruJ2/PKFya+WhbcVu7YmSdAhOLr6uH8XjY5wkR7UrAO6HY 4MuP0jPSmkz0klRk5VAFFjs44o+Da3GrfXSXcTC3UApe7X1MJ2OApn4emuUYNHZqdhR tPew4iP5Q== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id n156LwfE090314; Thu, 5 Feb 2009 07:21:58 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Thu, 05 Feb 2009 07:21:58 +0100 Message-ID: <20090205072158.23811u1p5tpfkakk@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 05 Feb 2009 07:21:58 +0100 From: Alexander Leidinger To: "M. Warner Losh" References: <4988AB83.2050203@gmx.de> <20090204212854.F51932@delplex.bde.org> <20090204154414.1949765y56lfhi80@webmail.leidinger.net> <20090204.103220.1763804960.imp@bsdimp.com> In-Reply-To: <20090204.103220.1763804960.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.3) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: 5B3E32E0F8.8CD74 X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, ORDB-RBL, SpamAssassin (not cached, score=-13.427, required 6, BAYES_00 -15.00, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, TW_SV 0.08) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, christoph.mallon@gmx.de, src-committers@freebsd.org, brde@optusnet.com.au Subject: Re: svn commit: r188098 - head/lib/libc/string X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2009 06:22:07 -0000 Quoting "M. Warner Losh" (from Wed, 04 Feb 2009 =20 10:32:20 -0700 (MST)): > In message: <20090204154414.1949765y56lfhi80@webmail.leidinger.net> > Alexander Leidinger writes: > : Quoting Bruce Evans (from Wed, 4 Feb 2009 > : 22:27:59 +1100 (EST)): > : > : > On Tue, 3 Feb 2009, Christoph Mallon wrote: > : > > : >> Warner Losh schrieb: > : >>> Modified: head/lib/libc/string/strmode.c > : >>> =20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > : >>> --- head/lib/libc/string/strmode.c=09Tue Feb 3 20:01:51 2009 (r1880= 97) > : >>> +++ head/lib/libc/string/strmode.c=09Tue Feb 3 20:25:36 2009 (r1880= 98) > : >>> @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); > : >>> #include > : >>> void > : >>> -strmode(mode_t mode, char *p) > : >>> +strmode(/* mode_t */ int mode, char *p) > : >>> { > : >>> =09 /* print type */ > : >>> =09switch (mode & S_IFMT) { > : >> > : >> The manpage states that the first parameter of strmode() is a > : >> mode_t. What's wrong - the implementation (both in header and > : >> definition) or the documentation? > : > > : > The man page is wrong. strtomode() should take an int arg (actually > : > the default (unary) promotion of a mode_t) for the the same reasons > : > that memchr() does -- because these interfaces should be usable by K&R > : > compilers and/or by standard C compilers without a protoype in scope. > : > Even if this is no longer required, binary compatibily requires the > : > interfaces to be the same as the ones that used to be required. The > : > requirement for binary compatibility also prevents "fixing" interfaces > : > to be "ANSI" in headers (if you "fix" prototypes there then you will > : > get obscure runtime errors instead of tinderbox errors). > : > : Is this also true for the current use of symbol versioning in our > : libc? I thought this is supposed to "fix" this problem (assuming we > : add an UPDATING entry that users have to make sure that they to a full > : installworld to habe the includes and the lib in sync)? > > Maybe, but it is a problem worth fixing? What we have now is correct It depends if this is seen as a broken window =20 (http://www.pragprog.com/the-pragmatic-programmer/extracts/software-entropy)= =20 or not... At least we should not talk a lot against fixing it. If someone wants =20 to fix it, he should be welcome. Bye, Alexander. --=20 Phosflink, v: =09To flick a bulb on and off when it burns out (as if, somehow, =09that will bring it back to life). =09=09-- Rich Hall & Friends, "Sniglets" http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137