From owner-p4-projects@FreeBSD.ORG Tue Apr 24 02:17:08 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 596D416A402; Tue, 24 Apr 2007 02:17:08 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1481E16A401 for ; Tue, 24 Apr 2007 02:17:08 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0586313C448 for ; Tue, 24 Apr 2007 02:17:08 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3O2H7Rf019569 for ; Tue, 24 Apr 2007 02:17:07 GMT (envelope-from kmacy@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3O2H7pA019566 for perforce@freebsd.org; Tue, 24 Apr 2007 02:17:07 GMT (envelope-from kmacy@freebsd.org) Date: Tue, 24 Apr 2007 02:17:07 GMT Message-Id: <200704240217.l3O2H7pA019566@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to kmacy@freebsd.org using -f From: Kip Macy To: Perforce Change Reviews Cc: Subject: PERFORCE change 118693 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2007 02:17:08 -0000 http://perforce.freebsd.org/chv.cgi?CH=118693 Change 118693 by kmacy@kmacy_storage:opentoe_work on 2007/04/24 02:16:15 minor "notyet" cleanup Affected files ... .. //depot/projects/opentoe/sys/dev/cxgb/cxgb_adapter.h#10 edit .. //depot/projects/opentoe/sys/dev/cxgb/cxgb_offload.c#8 edit .. //depot/projects/opentoe/sys/dev/cxgb/cxgb_sge.c#10 edit .. //depot/projects/opentoe/sys/dev/cxgb/cxgb_toedev.h#6 edit Differences ... ==== //depot/projects/opentoe/sys/dev/cxgb/cxgb_adapter.h#10 (text+ko) ==== @@ -150,6 +150,7 @@ uint32_t offload_pkts; uint32_t offload_bundles; uint32_t pure_rsps; + uint32_t unhandled_irqs; bus_addr_t phys_addr; bus_dma_tag_t desc_tag; ==== //depot/projects/opentoe/sys/dev/cxgb/cxgb_offload.c#8 (text+ko) ==== @@ -305,9 +305,7 @@ req->pbl_top = t3_read_reg(adapter, A_ULPTX_PBL_ULIMIT); req->rqt_base = t3_read_reg(adapter, A_ULPRX_RQ_LLIMIT); req->rqt_top = t3_read_reg(adapter, A_ULPRX_RQ_ULIMIT); -#ifdef notyet - req->kdb_addr = adapter->regs + A_SG_KDOORBELL; -#endif + req->kdb_addr = rman_get_start(adapter->regs_res) + A_SG_KDOORBELL; break; } case RDMA_CQ_OP: { @@ -583,12 +581,12 @@ struct toe_tid_entry *p = &td->tid_maps.tid_tab[tid]; mtx_lock(&td->tid_release_lock); - p->ctx = (void *)td->tid_release_list; + p->ctx = td->tid_release_list; td->tid_release_list = p; -#ifdef notyet + if (!p->ctx) - schedule_work(&td->tid_release_task); -#endif + taskqueue_enqueue(tdev->adapter->tq, &td->tid_release_task); + mtx_unlock(&td->tid_release_lock); } ==== //depot/projects/opentoe/sys/dev/cxgb/cxgb_sge.c#10 (text+ko) ==== @@ -2502,11 +2502,8 @@ struct sge_rspq *rspq = &qs->rspq; mtx_lock(&rspq->lock); - if (process_responses_gts(adap, rspq) == 0) { -#ifdef notyet + if (process_responses_gts(adap, rspq) == 0) rspq->unhandled_irqs++; -#endif - } mtx_unlock(&rspq->lock); } ==== //depot/projects/opentoe/sys/dev/cxgb/cxgb_toedev.h#6 (text+ko) ==== @@ -50,8 +50,8 @@ struct toedev { char name[TOENAMSIZ]; /* T3C device name */ enum toetype type; - TAILQ_ENTRY(toedev) ofld_entry; struct ifnet *lldev; /* LL dev associated with T3C messages */ + struct adapter *adapter; int (*send)(struct toedev *dev, struct mbuf *m); int (*recv)(struct toedev *dev, struct mbuf **m, int n); @@ -65,6 +65,7 @@ void *l3opt; /* optional layer 3 data */ void *l4opt; /* optional layer 4 data */ void *ulp; /* ulp stuff */ + TAILQ_ENTRY(toedev) ofld_entry; }; #endif /* _TOEDEV_H_ */