From owner-cvs-src@FreeBSD.ORG Thu May 24 05:02:58 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9ACC416A41F; Thu, 24 May 2007 05:02:58 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx03.syd.optusnet.com.au (fallbackmx03.syd.optusnet.com.au [211.29.133.136]) by mx1.freebsd.org (Postfix) with ESMTP id 387A113C447; Thu, 24 May 2007 05:02:58 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail32.syd.optusnet.com.au (mail32.syd.optusnet.com.au [211.29.132.63]) by fallbackmx03.syd.optusnet.com.au (8.12.11.20060308/8.12.11) with ESMTP id l4NBM09b001120; Wed, 23 May 2007 21:22:00 +1000 Received: from besplex.bde.org (c211-30-216-190.carlnfd3.nsw.optusnet.com.au [211.30.216.190]) by mail32.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l4NBLsxS020315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 May 2007 21:21:57 +1000 Date: Wed, 23 May 2007 21:21:55 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Robert Watson In-Reply-To: <200705230932.l4N9WUME017084@repoman.freebsd.org> Message-ID: <20070523203938.M10628@besplex.bde.org> References: <200705230932.l4N9WUME017084@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/security/audit audit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2007 05:02:58 -0000 On Wed, 23 May 2007, Robert Watson wrote: > rwatson 2007-05-23 09:32:30 UTC > > FreeBSD src repository > > Modified files: > sys/security/audit audit.c > Log: > No need to force __inline__ of currecord(), as the compiler will usefully > inline it when needed already, and the symbol is also required outside of > audit.c. This silences a new gcc warning on the topic of using __inline__ > instead of __inline. Er, the warning is the same for all of (non-static) inline, __inline and __inline__. For compiling "__inline int foo(int x)..." with -std=c99 and no other compiler options it is: z.c:2: warning: C99 inline functions are not supported; using GNU89 z.c:2: warning: to disable this warning use -fgnu89-inline or the gnu_inline function attribute The wording of this warning is confusing. Non-static inline functions are a gnu89 feature that no longer works by default with -std=c99. The first line of the warning seems to be just an excessively abbreivated way of saying "in C99, GNU89 inline functions are not supported; using GNU89 mode to do what you mean". The second line of the warning then describes in a better way how to enable this gnu89 feature without getting the warning. With -std=c89, GNU89 inline functions are of course supported, but "inline" in them must be spelled either __inline or __inline__ since "inline" is in the application namespace for c89. This problem also affects i386/pmap.c. The non-static inlines there are similarly dubious. But inlining shouldn't happen automatically below -O3. Bruce