Date: Tue, 24 Sep 2013 22:32:23 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Christian Weisgerber <naddy@FreeBSD.org>
Cc: freebsd-ports@freebsd.org
Subject: Re: Options: ${opt}_CPPFLAGS?
Message-ID: <20130924203223.GD13577@ithaqua.etoilebsd.net>
In-Reply-To: <20130924191808.GA78968@lorvorc.mips.inka.de>
References: <l1sie2$28t0$1@lorvorc.mips.inka.de> <20130924182808.GB13577@ithaqua.etoilebsd.net> <20130924191808.GA78968@lorvorc.mips.inka.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--8nsIa27JVQLqB7/C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Sep 24, 2013 at 09:18:08PM +0200, Christian Weisgerber wrote:
> Baptiste Daroussin:
>=20
> > > | If X_ABOVEVARIABLE is defined then its value will be appended to
> > > | ABOVEVARIABLE depending on the status of the option X
> > >=20
> > > ... which agrees with bsd.options.mk. But shouldn't this also
> > > include CPPFLAGS?
> >=20
> > Good idea, patch welcome :)
>=20
> Index: bsd.options.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- bsd.options.mk (revision 328190)
> +++ bsd.options.mk (working copy)
> @@ -93,9 +93,9 @@
> # ${opt}_CMAKE_OFF When option is disabled, it will add its content to
> # the CMAKE_ARGS.
> #
> -# For each of CFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV USES DISTFI=
LES,
> -# defining ${opt}_${variable} will add it to the actual variable when the
> -# option is enabled.
> +# For each of CFLAGS CPPFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV US=
ES
> +# DISTFILES, defining ${opt}_${variable} will add it to the actual varia=
ble
> +# when the option is enabled.
> #
> # For each of the depends target PKG EXTRACT PATCH FETCH BUILD LIB RUN,
> # defining ${opt}_${deptype}_DEPENDS will add it to the actual dependenc=
y when
> @@ -392,7 +392,7 @@
> . if defined(${opt}_CMAKE_ON)
> CMAKE_ARGS+=3D ${${opt}_CMAKE_ON}
> . endif
> -. for flags in CFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV USES DI=
STFILES
> +. for flags in CFLAGS CPPFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_EN=
V USES DISTFILES
> . if defined(${opt}_${flags})
> ${flags}+=3D ${${opt}_${flags}}
> . endif
>=20
> --=20
> Christian "naddy" Weisgerber naddy@mips.inka.de
Approves please co mit
regards,
Bapt
--8nsIa27JVQLqB7/C
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlJB9tcACgkQ8kTtMUmk6EzBfgCeOISI/TjsN9DjqYXVO2kv1n66
0uEAn2wZczdVPkKXx5q4z9OHH7j0qoOr
=kV2c
-----END PGP SIGNATURE-----
--8nsIa27JVQLqB7/C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130924203223.GD13577>