Date: Mon, 11 May 1998 12:07:19 +0200 From: Wolfram Schneider <wosch@cs.tu-berlin.de> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: wosch@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG, freebsd-gnats-submit@FreeBSD.ORG Subject: Re: bin/6550 Message-ID: <19980511120719.A7813@caramba.cs.tu-berlin.de> In-Reply-To: <14163.894875793@critter.freebsd.dk>; from Poul-Henning Kamp on Mon, May 11, 1998 at 10:36:33AM %2B0200 References: <19980510223247.09270@panke.de> <14163.894875793@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1998-05-11 10:36:33 +0200, Poul-Henning Kamp wrote: > In message <19980510223247.09270@panke.de>, Wolfram Schneider writes: > >On 1998-05-10 12:57:25 -0700, Poul-Henning Kamp wrote: > >> Synopsis: make(1): shell meta-character optimization incomplete > >> > >> State-Changed-From-To: open-closed > > > >*grumble* > > > >Our make is broken, period! Why did you closed the PR? > >Please fix the bugs or reopen the PR again! > > Our make is not broken (at least in this particular respect.) It is broken. > There is not really any reason (apart from speed) for implementing > the shell commands, consequently it cannot be said to be broken > because it doesn't. You did not understand the problem ;-( The current algorithm is if (no_meta_characters(command)) exec(command) else /bin/sh -c "command" where it should be if (no_meta_characters(command) && no_shell_builtin(command)) exec(command) else /bin/sh -c "command" > If you want it to support more builtins, something which I am not > as such against, while on the other hand I don't see any reason to > do it, the very least you can do is to submit a patch. I got now a patch from Theo de Raadt. I will check if the patch works. -- Wolfram Schneider <wosch@freebsd.org> http://www.freebsd.org/~wosch/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980511120719.A7813>