Date: Tue, 16 Dec 2008 15:05:35 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r186180 - head/sys/netinet Message-ID: <200812161505.mBGF5ZZu040527@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rwatson Date: Tue Dec 16 15:05:35 2008 New Revision: 186180 URL: http://svn.freebsd.org/changeset/base/186180 Log: IPFW's pfil hook/unhook code ignores the return values of pfil_add_hook() and pfil_remove_hook(), so cast them to (void). MFC after: pretty soon Modified: head/sys/netinet/ip_fw_pfil.c Modified: head/sys/netinet/ip_fw_pfil.c ============================================================================== --- head/sys/netinet/ip_fw_pfil.c Tue Dec 16 13:58:37 2008 (r186179) +++ head/sys/netinet/ip_fw_pfil.c Tue Dec 16 15:05:35 2008 (r186180) @@ -435,8 +435,10 @@ ipfw_hook(void) if (pfh_inet == NULL) return ENOENT; - pfil_add_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, pfh_inet); - pfil_add_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, pfh_inet); + (void)pfil_add_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, + pfh_inet); + (void)pfil_add_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, + pfh_inet); return 0; } @@ -450,8 +452,10 @@ ipfw_unhook(void) if (pfh_inet == NULL) return ENOENT; - pfil_remove_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, pfh_inet); - pfil_remove_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, pfh_inet); + (void)pfil_remove_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, + pfh_inet); + (void)pfil_remove_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, + pfh_inet); return 0; } @@ -466,8 +470,10 @@ ipfw6_hook(void) if (pfh_inet6 == NULL) return ENOENT; - pfil_add_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, pfh_inet6); - pfil_add_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, pfh_inet6); + (void)pfil_add_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, + pfh_inet6); + (void)pfil_add_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, + pfh_inet6); return 0; } @@ -481,8 +487,10 @@ ipfw6_unhook(void) if (pfh_inet6 == NULL) return ENOENT; - pfil_remove_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, pfh_inet6); - pfil_remove_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, pfh_inet6); + (void)pfil_remove_hook(ipfw_check_in, NULL, PFIL_IN | PFIL_WAITOK, + pfh_inet6); + (void)pfil_remove_hook(ipfw_check_out, NULL, PFIL_OUT | PFIL_WAITOK, + pfh_inet6); return 0; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812161505.mBGF5ZZu040527>