From owner-cvs-ports@FreeBSD.ORG  Sun Sep  6 18:51:59 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 6900E106568D; Sun,  6 Sep 2009 18:51:59 +0000 (UTC)
Date: Sun, 6 Sep 2009 18:51:59 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jimmy Olgeni <olgeni@FreeBSD.org>
Message-ID: <20090906185159.GA53124@FreeBSD.org>
References: <200909061320.n86DK7de072438@repoman.freebsd.org>
	<20090906172642.GA42149@FreeBSD.org>
	<alpine.BSF.2.00.0909061939240.36316@olgeni.olgeni>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.0909061939240.36316@olgeni.olgeni>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/erlang Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Sep 2009 18:51:59 -0000

On Sun, Sep 06, 2009 at 07:43:07PM +0200, Jimmy Olgeni wrote:
> On Sun, 6 Sep 2009, Alexey Dokuchaev wrote:
> >On Sun, Sep 06, 2009 at 01:20:07PM +0000, Jimmy Olgeni wrote:
> >>olgeni      2009-09-06 13:20:07 UTC
> >>
> >>  FreeBSD ports repository
> >>
> >>  Modified files:
> >>    lang/erlang          Makefile
> >>  Log:
> >>  Use "+=" rather than "=" when modifying CONFIGURE_ENV.
> >
> >It could be useful to know what was particularly wrong with "=" without
> >reading through Makefile.
> 
> In this case it was overriding a CONFIGURE_ENV a few lines above, thus 
> losing the JDK path setting. Should I follow up with a forced commit?

This case is simple enough so it's probably not worth it, but thanks for
explanation.

./danfe