From owner-svn-src-all@FreeBSD.ORG  Mon Dec  1 22:09:33 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 660F21C1;
 Mon,  1 Dec 2014 22:09:33 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 47DF6EF3;
 Mon,  1 Dec 2014 22:09:32 +0000 (UTC)
Received: from bender.lan (97e078e7.skybroadband.com [151.224.120.231])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id B99167328F;
 Mon,  1 Dec 2014 22:09:30 +0000 (UTC)
Date: Mon, 1 Dec 2014 22:09:14 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Ian Lepore <ian@FreeBSD.org>
Subject: Re: svn commit: r275379 - head/share/mk
Message-ID: <20141201220914.14b1bf6f@bender.lan>
In-Reply-To: <1417469782.1064.38.camel@revolution.hippie.lan>
References: <201412012107.sB1L7a8j057922@svn.freebsd.org>
 <1417469782.1064.38.camel@revolution.hippie.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Andrew Turner <andrew@FreeBSD.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 22:09:33 -0000

On Mon, 01 Dec 2014 14:36:22 -0700
Ian Lepore <ian@FreeBSD.org> wrote:

> On Mon, 2014-12-01 at 21:07 +0000, Andrew Turner wrote:
> > Author: andrew
> > Date: Mon Dec  1 21:07:36 2014
> > New Revision: 275379
> > URL: https://svnweb.freebsd.org/changeset/base/275379
> > 
> > Log:
> >   Set the correct architecture when targeting ARMv7
> >   
> >   MFC after:	1 Week
> >   Sponsored by:	ABT Systems Ltd
> > 
> > Modified:
> >   head/share/mk/bsd.cpu.mk
> > 
> > Modified: head/share/mk/bsd.cpu.mk
> > ==============================================================================
> > --- head/share/mk/bsd.cpu.mk	Mon Dec  1 21:04:26 2014
> > (r275378) +++ head/share/mk/bsd.cpu.mk	Mon Dec  1 21:07:36
> > 2014	(r275379) @@ -99,7 +99,7 @@ _CPUCFLAGS = -march=armv5te
> > -D__XSCALE__ . elif ${CPUTYPE} == "armv6"
> >  _CPUCFLAGS = -march=${CPUTYPE} -DARM_ARCH_6=1
> >  . elif ${CPUTYPE} == "cortexa"
> > -_CPUCFLAGS = -DARM_ARCH_6=1 -mfpu=vfp
> > +_CPUCFLAGS = -march=armv7 -DARM_ARCH_6=1 -mfpu=vfp
> >  .  else
> >  _CPUCFLAGS = -mcpu=${CPUTYPE}
> >  .  endif
> > 
> 
> Doesn't cortex-a also imply vfp3?

The vfp looks to be incorrect as it's optional on ARMv7. If present I
think it will be either a VFPv3 or v4 depending on the core.

I also think we could remove the "-DARM_ARCH_6=1" as, if it's used at
all, it can be replaced with a combination of <machine/acle-compat.h>
and __ARM_ARCH >= 6.

Andrew