Date: Fri, 17 Jun 2016 09:56:47 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301959 - head/sys/kern Message-ID: <ebb1a491-e279-83e0-20b3-955679c3d2ac@FreeBSD.org> In-Reply-To: <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org> References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> <20160617061306.GS38613@kib.kiev.ua> <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX Content-Type: multipart/mixed; boundary="MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <ebb1a491-e279-83e0-20b3-955679c3d2ac@FreeBSD.org> Subject: Re: svn commit: r301959 - head/sys/kern References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> <20160617061306.GS38613@kib.kiev.ua> <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org> In-Reply-To: <c0f54ecb-c78f-2551-e048-89ef95f3d53f@FreeBSD.org> --MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/17/2016 9:51 AM, Bryan Drewery wrote: > On 6/16/2016 11:13 PM, Konstantin Belousov wrote: >> On Thu, Jun 16, 2016 at 10:17:19AM -0700, Conrad Meyer wrote: >>> style(9) nit: /* FALLTHROUGH */ >> >> FALLTHROUGH is only applicable when there are executable statements fo= r >> both cases, and first sequence of statements does not end in break. >> Look at the switch() example right after the FALLTHROUGH requirement >> in the style(9), which shows case '?'. >> >=20 > Yes the example shows code in both cases, but the text about it is more= > strict "Elements in a switch statement that cascade should have a > FALLTHROUGH comment." >=20 My personal opinion does agree with your interpretation. I think we should clarify style.9 about when to use FALLTHROUGH. --=20 Regards, Bryan Drewery --MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9-- --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXZCvQAAoJEDXXcbtuRpfPLkYIAKSuGvE4HjTdSq7Xbh3DNH6p AzTLallgZF2NBKgYbkLSmrxLsNg2Nx7u0utcJ9AoHiftpd6nhJqQC5+Uu5j1XRaK T0f15uc14owJnWj4s4jGTVHzDzklHkbDqGq/GczDA9dVqmJyLqDTdyIT0eZjB+es bbGemsUUpigtTq9yGxMn0zA4o71lFCHQLMCKqce3/YABdQQHTX5S2jQEeAtKmeuT xdqh1KFADxPsTaMal9yscH3VEwQ7tq+MLXgxwvPwfw2H1ohUGPdLU/Zjw6R207xs 28mSuOTE8WYMvl7l5mSEzob/99CqmvIIiVpXB7X9chKv77vMmVn//KT05oeE3fE= =Sk26 -----END PGP SIGNATURE----- --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ebb1a491-e279-83e0-20b3-955679c3d2ac>